[ 
https://issues.apache.org/jira/browse/CASSANDRA-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107195#comment-15107195
 ] 

Paulo Motta commented on CASSANDRA-10948:
-----------------------------------------

+1, just minor change to use {{self.encoding}} instead of hard-coding 
{{utf-8}}, to avoid problems when using other encodings.

Will mark as ready to commit once tests look good:
||2.2||3.0||3.3||trunk||
|[branch|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:2.2-10948]|[branch|https://github.com/apache/cassandra/compare/cassandra-3.0...pauloricardomg:3.0-10948]|[branch|https://github.com/apache/cassandra/compare/cassandra-3.3...pauloricardomg:3.3-10948]|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-10948]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.2-10948-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.0-10948-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.3-10948-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10948-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.2-10948-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.0-10948-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.3-10948-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10948-dtest/lastCompletedBuild/testReport/]|

Thanks!


> CQLSH error when trying to insert non-ascii statement
> -----------------------------------------------------
>
>                 Key: CASSANDRA-10948
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10948
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Matthieu Nantern
>            Priority: Minor
>              Labels: lhf
>         Attachments: patch_CASSANDRA-10948
>
>
> We recently upgraded Cassandra to v2.2.4 with CQLSH 5.0.1 and we are now 
> unable to import some CQL file (with French character like 'ê'). It was 
> working on v2.0.12.
> The issue:
> {noformat}
> Using CQL driver: <module 'cassandra' from 
> '/OPT/cassandra/dsc-cassandra-2.2.4/bin/../lib/cassandra-driver-internal-only-3.0.0-6af642d.zip/cassandra-driver-3.0.0-6af642d/cassandra/__init__.py'>
> Using connect timeout: 5 seconds
> Traceback (most recent call last):
>   File "/OPT/cassandra/dsc-cassandra/bin/cqlsh.py", line 1110, in onecmd
>     self.handle_statement(st, statementtext)
>   File "/OPT/cassandra/dsc-cassandra/bin/cqlsh.py", line 1135, in 
> handle_statement
>     readline.add_history(new_hist)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xea' in position 
> 7192: ordinal not in range(128)
> {noformat}
> The issue was corrected by changing line 1135 of cqlsh.py (but I don't know 
> if it's the correct way to do it):
> readline.add_history(new_hist)  -> 
> readline.add_history(new_hist.encode('utf8'))



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to