[ 
https://issues.apache.org/jira/browse/CASSANDRA-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214616#comment-15214616
 ] 

Paulo Motta commented on CASSANDRA-8777:
----------------------------------------

This will be useful for cases when there is an error before the connection was 
established, such as the exception trace shown by Brandon. But it would be nice 
to add the endpoint and port to other stream statements while the stream is 
connected.

We currently name the {{MessageHandler}} thread after the remote peer address, 
so the thread name/peer IP is automatically logged during any stream session 
log statement. We should probably use the remote socket address instead, so 
both IP and port will be logged, similar to what is done on 
{{IncomingStreamingConnection}}.

Minor nits:
* thorow -> through
* since {{connecting}} is almost always equal to {{peer}}, it's probably good 
to use [this 
trick|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamSession.java#L239]
 to log {{connecting}} only when its different from {{peer}}.

> Streaming operations should log both endpoint and port associated with the 
> operation
> ------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8777
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8777
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jeremy Hanna
>              Labels: lhf
>             Fix For: 2.1.x
>
>         Attachments: 8777-2.2.txt
>
>
> Currently we log the endpoint for a streaming operation.  If the port has 
> been overridden, it would be valuable to know that that setting is getting 
> picked up.  Therefore, when logging the endpoint address, it would be nice to 
> also log the port it's trying to use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to