[ https://issues.apache.org/jira/browse/CASSANDRA-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904074#comment-15904074 ]
Michael Kjellman commented on CASSANDRA-13317: ---------------------------------------------- p.s. [~aweisberg] there is a performance penalty here which is why it's disabled by default in logback and log4j2.. I think it's helpful to have the filename and line number personally while debugging so I think it makes sense to keep %F:%L in the pattern for logback-test.xml... For the actual default conf we ship I wonder if it might make sense to remove "%F:%L" from the pattern instead of fixing the issue.... The thing is though that we ship this "ASYNCDEBUGLOG" appender enabled by default though which already has <includeCallerData>true</includeCallerData>..... so if we decide it's not worth the performance overhead to log the filename and line number for the actual default (non-test) logback config we ship we should also make ASYNCDEBUGLOG disabled by default... {code} <root level="INFO"> <appender-ref ref="SYSTEMLOG" /> <appender-ref ref="STDOUT" /> <appender-ref ref="ASYNCDEBUGLOG" /> <!-- Comment this line to disable debug.log --> <!-- <appender-ref ref="LogbackMetrics" /> --> </root> {code} > Default logging we ship will incorrectly print "?:?" for "%F:%L" pattern due > to includeCallerData being false by default no appender > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: CASSANDRA-13317 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13317 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Michael Kjellman > Assignee: Michael Kjellman > Attachments: 13317_v1.diff > > > We specify the logging pattern as "%-5level [%thread] %date{ISO8601} %F:%L - > %msg%n". > %F:%L is intended to print the Filename:Line Number. For performance reasons > logback (like log4j2) disables tracking line numbers as it requires the > entire stack to be materialized every time. > This causes logs to look like: > WARN [main] 2017-03-09 13:27:11,272 ?:? - Protocol Version 5/v5-beta not > supported by java driver > INFO [main] 2017-03-09 13:27:11,813 ?:? - No commitlog files found; skipping > replay > INFO [main] 2017-03-09 13:27:12,477 ?:? - Initialized prepared statement > caches with 14 MB > INFO [main] 2017-03-09 13:27:12,727 ?:? - Initializing system.IndexInfo > When instead you'd expect something like: > INFO [main] 2017-03-09 13:23:44,204 ColumnFamilyStore.java:419 - > Initializing system.available_ranges > INFO [main] 2017-03-09 13:23:44,210 ColumnFamilyStore.java:419 - > Initializing system.transferred_ranges > INFO [main] 2017-03-09 13:23:44,215 ColumnFamilyStore.java:419 - > Initializing system.views_builds_in_progress > The fix is to add "<includeCallerData>true</includeCallerData>" to the > appender config to enable the line number and stack tracing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)