[
https://issues.apache.org/jira/browse/CASSANDRA-13272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076144#comment-16076144
]
Benjamin Lerer commented on CASSANDRA-13272:
--------------------------------------------
I had a look at the sources and I am not sure to understand the purpose of the
original code. Everywhere else in {{StorageService}} the full chain of
Exceptions is being logged.
If the wrapping Exception was created without a message it will automatically
use the message of the wrapped exception. Due to that, we should probably use:
{code}
@Override
public void onFailure(Throwable e)
{
String message = "Error during bootstrap: " +
e.getMessage();
logger.error(message, e);
progressSupport.progress("bootstrap", new
ProgressEvent(ProgressEventType.ERROR, 1, 1, message));
progressSupport.progress("bootstrap", new
ProgressEvent(ProgressEventType.COMPLETE, 1, 1, "Resume bootstrap complete"));
}
{code}
[~yukim] Do you remember why you used the exception cause instead of the
exception?
> "nodetool bootstrap resume" does not exit
> -----------------------------------------
>
> Key: CASSANDRA-13272
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13272
> Project: Cassandra
> Issue Type: Bug
> Components: Lifecycle, Streaming and Messaging
> Reporter: Tom van der Woerdt
> Assignee: Tim Lamballais
> Labels: lhf
>
> I have a script that calls "nodetool bootstrap resume" after a failed join
> (in my environment some streams sometimes fail due to mis-tuning of stream
> bandwidth settings). However, if the streams fail again, nodetool won't exit.
> Last lines before it just hangs forever :
> {noformat}
> [2017-02-26 07:02:42,287] received file
> /var/lib/cassandra/data/keyspace/table-63d5d42009fa11e5879ebd9463bffdac/mc-12670-big-Data.db
> (progress: 1112%)
> [2017-02-26 07:02:42,287] received file
> /var/lib/cassandra/data/keyspace/table-63d5d42009fa11e5879ebd9463bffdac/mc-12670-big-Data.db
> (progress: 1112%)
> [2017-02-26 07:02:59,843] received file
> /var/lib/cassandra/data/keyspace/table-63d5d42009fa11e5879ebd9463bffdac/mc-12671-big-Data.db
> (progress: 1112%)
> [2017-02-26 09:25:51,000] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 09:33:45,017] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 09:39:27,216] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 09:53:33,084] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 09:55:07,115] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 10:06:49,557] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 10:40:55,880] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 11:09:21,025] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 12:44:35,755] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 12:49:18,867] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 13:23:50,611] session with /10.x.y.z complete (progress: 1112%)
> [2017-02-26 13:23:50,612] Stream failed
> {noformat}
> At that point ("Stream failed") I would expect nodetool to exit with a
> non-zero exit code. Instead, it just wants me to ^C it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
