[ 
https://issues.apache.org/jira/browse/CASSANDRA-8527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297976#comment-16297976
 ] 

Alexander Dejanovski commented on CASSANDRA-8527:
-------------------------------------------------

I pushed a small fix in my branch to avoid counting some rows in both 
{{deletedRows}} and {{tombstones}}.

If all cells in a row have expired then each will get counted as a tombstone 
but it will also make {{row.hasLiveData() }} return false. 
I've changed the test to : 

{code:java}
if (row.hasLiveData(ReadCommand.this.nowInSec(), enforceStrictLiveness))
    ++liveRows;
else if (!row.primaryKeyLivenessInfo().isLive(ReadCommand.this.nowInSec()))
{
    ++deletedRows;
}
{code}

Also started the discussion on the dev ML today.

> Account for range tombstones wherever we account for tombstones
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-8527
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8527
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Alexander Dejanovski
>             Fix For: 4.x
>
>         Attachments: CASSANDRA-8527.diff
>
>
> As discussed in CASSANDRA-8477, we should make sure the tombstone thresholds 
> also apply to range tombstones, since they poses the same problems than cell 
> tombstones.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to