[ 
https://issues.apache.org/jira/browse/CASSANDRA-14116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420961#comment-16420961
 ] 

Blake Eggleston commented on CASSANDRA-14116:
---------------------------------------------

bq. The {{Predicate}} in the original includes the additional cluases on the if 
statement

{{SnapshotTask}} isn't run in incremental repairs (see {{RepairJob#run}}), so 
that line would always evaluate to true.

bq. Is this a decent time to switch from the guava Predicate and 
ListenableFuture type uses, and switch to the JDK equivalents?

I'm not personally concerned with it, and I think it would be better as it's 
own ticket if/when we decided to do it.

> Refactor repair
> ---------------
>
>                 Key: CASSANDRA-14116
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14116
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Repair
>            Reporter: Dikang Gu
>            Assignee: Blake Eggleston
>            Priority: Major
>             Fix For: 4.0
>
>
> As part of the pluggable storage engine effort, we'd like to modularize the 
> repair related code, make it to be independent from existing storage engine 
> implementation details.
> For now, refer to 
> https://docs.google.com/document/d/1suZlvhzgB6NIyBNpM9nxoHxz_Ri7qAm-UEO8v8AIFsc
>  for high level designs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to