[ 
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976807#comment-16976807
 ] 

Yifan Cai commented on CASSANDRA-15429:
---------------------------------------

[~drohrer] and I co-worked on it.

The changes in the PRs 
 # added {{NodeProbeFactory}} field in NodeTool. The field can be set to the 
mock version, {{InternalNodeProbeFactory}} when running dtest. 
 # added {{InternalNodeProbe}} that extends {{NodeProbe}}. It supports a subset 
of the nodetool functionality. The unsupported operations are basically 
'printing info onto terminal' or similar display ops, which dtest has little 
interest in.
 # The changes to the production code, i.e. under the {{tools}} package, is 
made minimal. All existing functionality of nodetool should work as is.

||PR||
|[trunk|https://github.com/apache/cassandra/pull/385]|
|[cassandra-3.11|https://github.com/apache/cassandra/pull/386]|
|[cassandra-3.0|https://github.com/apache/cassandra/pull/387]|
|[cassandra-2.2|https://github.com/apache/cassandra/pull/388]|

> Support NodeTool for in-jvm dtest
> ---------------------------------
>
>                 Key: CASSANDRA-15429
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15429
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Test/dtest
>            Reporter: Yifan Cai
>            Assignee: Yifan Cai
>            Priority: Normal
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> In-JVM dtest framework does not support nodetool as of now. This 
> functionality is wanted in some tests, e.g. constructing an end-to-end test 
> scenario that uses nodetool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to