[
https://issues.apache.org/jira/browse/CASSANDRA-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016203#comment-17016203
]
Yifan Cai commented on CASSANDRA-15499:
---------------------------------------
Thanks [~aleksey].
Agree that {{withParams()}} is the intended way to add the trace headers and
other fields, especially after seeing the unit test cases. However, I feel it
is quite easy to forget adding the trace headers, and the logic of check and
add is applicable to all outing messages. It, in certain degree, becomes an
intrinsic step of building a message. Does it sound a valid argument?
Regarding helper, probably adding a method in the builder, say
{{withTracingMaybe(tracing: Tracing)}}, if the above does not sound good. And
call this method for building every message...
> Internode message builder does not add trace header
> ---------------------------------------------------
>
> Key: CASSANDRA-15499
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15499
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
> Reporter: Yifan Cai
> Assignee: Yifan Cai
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.x
>
>
> The messages built with the {{Builder}}
> ({{org.apache.cassandra.net.Message.Builder}}) do not have the trace header
> when tracing is enabled.
> Consequently, no tracing session gets propagated to other nodes, and the
> tracing function is broken.
> The set of static {{out*}} methods provided (to create an out-bounding
> message) in Message do not have the issue. They can properly add the trace
> header when necessary.
> To be clear, only the {{Builder}} missed adding the tracing header and it
> should be fixed to be consistent with the {{out*}} methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
