[ 
https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218733#comment-17218733
 ] 

Berenguer Blasi edited comment on CASSANDRA-16121 at 10/22/20, 5:27 AM:
------------------------------------------------------------------------

Correct, those are 2 diff sets of tests.

At the time of this PR `test_describe_cluster_output` was failing 
(CASSANDRA-16098) but wasn't getting reported in jenkins, this is what 
trigerred me raising this ticket. So this SHA fails this test and you can run 
it locally to doublecheck. It is not fixed/rebased in this PR bc I needed a 
failing test to see that circleci was reporting failures correctly :-)

Should we rebase and run a new circleci/jenkins and then we have confirmation 
it A. reports failures B. now passes green?

Edit: That was a silly question lol. Rebased as it was an old PR, pushed and 
new CI passing green in the PR. Now we know both it's green and does indeed 
report failures.


was (Author: bereng):
Correct, those are 2 diff sets of tests.

At the time of this PR `test_describe_cluster_output` was failing 
(CASSANDRA-16098) but wasn't getting reported in jenkins, this is what 
trigerred me raising this ticket. So this SHA fails this test and you can run 
it locally to doublecheck. It is not fixed/rebased in this PR bc I needed a 
failing test to see that circleci was reporting failures correctly :-)

Should we rebase and run a new circleci/jenkins and then we have confirmation 
it A. reports failures B. now passes green?

> Circleci should run cqlshlib tests as well
> ------------------------------------------
>
>                 Key: CASSANDRA-16121
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16121
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI, Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> Currently circleci is not running cqlshlib tests. This resulted in some bugs 
> not being caught before committing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to