[
https://issues.apache.org/jira/browse/CASSANDRA-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh McKenzie updated CASSANDRA-18627:
--------------------------------------
Description:
In CASSANDRA-17931, some code was left over (\{{additionalBytes}},
{{{}additionalSSTables{}}}) inside the {{PendingRepairManager}} which, while
not explicitly hurting anything, provides for some confusion around when we do
or don't take additional values into account when adjusting for pending
operations when deciding what to do with upcoming repairs etc.
We should tidy that up and consider making the role of those methods / their
structure more clear between the \{{PendingRepairManager]} hierarchy and the
{{AbstractCompactionStrategy}} hierarchy to prevent further confusion.
was:
In CASSANDRA-17931, we failed to correctly take into account the
additionalSSTables and additionalBytes passed in in one of our calls to
{code}PendingRepairManager.getEstimatedRemainingTasks{code}
> Tidy up vestigial code left over after CASSANDRA-17931
> ------------------------------------------------------
>
> Key: CASSANDRA-18627
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18627
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair, Local/Compaction
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
> Fix For: 5.x
>
>
> In CASSANDRA-17931, some code was left over (\{{additionalBytes}},
> {{{}additionalSSTables{}}}) inside the {{PendingRepairManager}} which, while
> not explicitly hurting anything, provides for some confusion around when we
> do or don't take additional values into account when adjusting for pending
> operations when deciding what to do with upcoming repairs etc.
>
> We should tidy that up and consider making the role of those methods / their
> structure more clear between the \{{PendingRepairManager]} hierarchy and the
> {{AbstractCompactionStrategy}} hierarchy to prevent further confusion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
