[ 
https://issues.apache.org/jira/browse/CASSANDRA-19454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823466#comment-17823466
 ] 

Arun Ganesh commented on CASSANDRA-19454:
-----------------------------------------

[~maedhroz], thanks!

I have a [draft PR|https://github.com/apache/cassandra/pull/3158] up for trunk. 
I'm not sure if that's all there is to do. Also, how should I go about testing 
these changes?  I'll create another PR for 5.0 after I finish this one.

> Revert switch to approximate time in Dispatcher to avoid mixing with 
> nanoTime() in downstream timeout calculations
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19454
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19454
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Client
>            Reporter: Caleb Rackliffe
>            Assignee: Arun Ganesh
>            Priority: Normal
>             Fix For: 5.0.x, 5.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> CASSANDRA-15241 changed {{Dispatcher}} to use the {{approxTime}} 
> implementation of {{MonotonicClock}} rather than {{nanoTime()}}, but clock 
> drift between the two, can potentially cause queries to time out more 
> quickly. We should be able to revert the {{Dispatcher}} to use {{nanoTime()}} 
> again and similarly change {{QueriesTable} to {{nanoTime()}} as well for 
> consistency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to