[
https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832500#comment-17832500
]
Ekaterina Dimitrova commented on CASSANDRA-19428:
-------------------------------------------------
I rebased and ran a preliminary CI tests (skinny dev workflow but in private
infra) and it seems some of the last changes broke two tests:
||org.apache.cassandra.index.sai.functional.CompactionTest-_jdk11_x86_64
failures: 1|| || || ||
||Class||Method||Output||Duration||
|index.sai.functional.CompactionTest|testAntiCompaction-_jdk11_x86_64|Assertion
condition defined as a lambda expression in org.apache.cassandra.cql3.CQLTester
that uses java.lang.Runnable
[build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-4-big-SAI+aa+RowToToken.db,
build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-2-big-SAI+aa+RowToToken.db,
build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-1-big-SAI+aa+RowToToken.db]
expected:<2> but was:<3> within 15
seconds.-org.awaitility.core.ConditionTimeoutException: Assertion condition
defined as a lambda expression in org.apache.cassandra.cql3.CQLTester that uses
java.lang.Runnable
[build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-4-big-SAI+aa+RowToToken.db,
build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-2-big-SAI+aa+RowToToken.db,
build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-1-big-SAI+aa+RowToToken.db]
expected:<2> but was:<3> within 15 seconds. at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
at org.apache.cassandra.cql3.CQLTester.waitForAssert(CQLTester.java:1407) at
org.apache.cassandra.cql3.CQLTester.waitForAssert(CQLTester.java:1412) at
org.apache.cassandra.index.sai.functional.CompactionTest.testAntiCompaction(CompactionTest.java:115)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
Caused by: java.lang.AssertionError:
[build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-4-big-SAI+aa+RowToToken.db,
build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-2-big-SAI+aa+RowToToken.db,
build/test/cassandra/data/cql_test_keyspace/table_testanticompaction_01-6216d570eebc11ee898565731b7624ca/nb-1-big-SAI+aa+RowToToken.db]
expected:<2> but was:<3> at
org.apache.cassandra.index.sai.SAITester.verifyIndexFiles(SAITester.java:531)
at
org.apache.cassandra.index.sai.SAITester.verifyIndexFiles(SAITester.java:516)
at
org.apache.cassandra.index.sai.functional.CompactionTest.lambda$testAntiCompaction$1(CompactionTest.java:115)
at
org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
at
org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222)
at
org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)|16.015|
||org.apache.cassandra.index.sai.functional.SnapshotTest-_jdk11_x86_64
failures: 1|| || || ||
||Class||Method||Output||Duration||
|index.sai.functional.SnapshotTest|shouldTakeAndRestoreSnapshots-_jdk11_x86_64|Assertion
condition defined as a lambda expression in
org.apache.cassandra.cql3.CQLTester that uses java.lang.Runnable null within 15
seconds.-org.awaitility.core.ConditionTimeoutException: Assertion condition
defined as a lambda expression in org.apache.cassandra.cql3.CQLTester that uses
java.lang.Runnable null within 15 seconds. at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
at org.apache.cassandra.cql3.CQLTester.waitForAssert(CQLTester.java:1407) at
org.apache.cassandra.cql3.CQLTester.waitForAssert(CQLTester.java:1412) at
org.apache.cassandra.index.sai.functional.SnapshotTest.shouldTakeAndRestoreSnapshots(SnapshotTest.java:90)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
Caused by: java.lang.AssertionError at
org.apache.cassandra.index.sai.SAITester.verifyNoIndexFiles(SAITester.java:509)
at
org.apache.cassandra.index.sai.functional.SnapshotTest.lambda$shouldTakeAndRestoreSnapshots$0(SnapshotTest.java:90)
at
org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
at
org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222)
at
org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)|
I can reproduce the failures locally. The first fails after the standardization
of how we release SSTables in QueryController.
I haven't bisected the second one yet.
I will look at those on Monday.
> Clean up KeyRangeIterator classes
> ---------------------------------
>
> Key: CASSANDRA-19428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19428
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/2i Index
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 5.0-rc, 5.x
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Remove KeyRangeIterator.current and simplify
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
