[
https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833748#comment-17833748
]
Ekaterina Dimitrova edited comment on CASSANDRA-19428 at 4/3/24 9:33 PM:
-------------------------------------------------------------------------
Update:
CASSANDRA-14572 was committed just after I rebased. This means the cassandra
patch was not presented during the CI run, but the cassandra-dtest was
presented.
This lead to test_default_keyspaces_exist failing. After rebase (with no
conflicts) the test does not fail for me locally anymore.
The rest of the failures here are also presented in the final CASSANDRA-14572
CI run:
test_assassinate_valid_node - CASSANDRA-18753
test_bootstrap_with_reset_bootstrap_state - (?)
test_sstablelevelreset - (?)
test_sstableofflinerelevel - (?)
test_resumable_decommission - (?)
testConcurrentReadWriteWorkload-_jdk11 - seen in Butler but I did not find a
ticket (?)
simulationTest - (?)
testSplitBrainStartup-_jdk17 - (?)
discoveryTest - failed also with 14572 CI run, attributed to network glitch
([https://app.circleci.com/pipelines/github/driftx/cassandra/1539/workflows/31fe6cd5-e653-46f3-b44c-113568e275cf/jobs/79487/tests#failed-test-0)]
- ticket (?)
[~mmuzaf] , are those marked with (?) in my list ticketed? I did not find a
trace in Jira, except they were presented in your CI run from CASSANDRA-14572.
Failures not presented on that run, trying to reproduce them now, but they do
not seem related in any way to what we do here.
Plus 5.0 is clean run and the SAI code is almost identical in 5.0 and trunk.
test_simple_decommission -
testMixedVersionBlockDecom-_jdk17 -
testIncompleteState-oa_jdk17 -
I will update soon about these last 3
was (Author: e.dimitrova):
Update:
CASSANDRA-14572 was committed just after I rebased. This means the cassandra
patch was not presented during the CI run, but the cassandra-dtest was
presented.
This lead to test_default_keyspaces_exist failing. After rebase (with no
conflicts) the test does not fail for me locally anymore.
The rest of the failures here are also presented in the final CASSANDRA-14572
CI run:
test_assassinate_valid_node - CASSANDRA-18753
test_bootstrap_with_reset_bootstrap_state - (?)
test_sstablelevelreset - (?)
test_sstableofflinerelevel - (?)
test_resumable_decommission - (?)
testConcurrentReadWriteWorkload-_jdk11 - seen in Butler but I did not find a
ticket (?)
simulationTest - (?)
testSplitBrainStartup-_jdk17 - (?)
discoveryTest - failed also with 14572 CI run, attributed to network glitch
([https://app.circleci.com/pipelines/github/driftx/cassandra/1539/workflows/31fe6cd5-e653-46f3-b44c-113568e275cf/jobs/79487/tests#failed-test-0)]
- ticket (?)
[~mmuzaf] , are those marked with ? in my list ticketed? I did not find a trace
in Jira, except they were presented in your CI run from CASSANDRA-14572.
Failures not presented on that run, trying to reproduce them now, but they do
not seem related in any way to what we do here.
Plus 5.0 is clean run and the SAI code is almost identical in 5.0 and trunk.
test_simple_decommission -
testMixedVersionBlockDecom-_jdk17 -
testIncompleteState-oa_jdk17 -
I will update soon about these last 3
> Clean up KeyRangeIterator classes
> ---------------------------------
>
> Key: CASSANDRA-19428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19428
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/2i Index
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.0-rc, 5.x
>
> Attachments:
> Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Remove KeyRangeIterator.current and simplify
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
