[
https://issues.apache.org/jira/browse/CASSANDRA-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842420#comment-17842420
]
Brandon Williams edited comment on CASSANDRA-19578 at 4/30/24 3:21 PM:
-----------------------------------------------------------------------
I see, thanks. In that case, even though this is in 4.1 I don't think we
should release 5.0 with it present. To that end, I added a small fix for the
test
[here|https://github.com/driftx/cassandra/commit/6ec147868d92c57e27959c513f70a5e597ef1192]
which hopefully results in clean CI:
||Branch||CI||
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-19578-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1614/workflows/ac2b40a8-7275-464f-9a1b-96f08d9c703d],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1614/workflows/d6f7fd59-bcd1-41b6-96a2-b4ca5b7ee1ad]|
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19578-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1615/workflows/b03ed4d4-ed4c-4dcb-b3eb-f29436a35067],
[j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1615/workflows/ddba8908-224a-4b89-9071-e9fc4813b7d3]|
was (Author: brandon.williams):
I see, thanks. In that case, even though this is in 4.1 I don't think we
should release 5.0 with it present. To that end, I added a small fix for the
test
[here|https://github.com/driftx/cassandra/commit/6ec147868d92c57e27959c513f70a5e597ef1192]
which hopefully results in clean CI:
||Branch||CI||
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-19578-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1614/workflows/ac2b40a8-7275-464f-9a1b-96f08d9c703d],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1614/workflows/d6f7fd59-bcd1-41b6-96a2-b4ca5b7ee1ad]|
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19578-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1613/workflows/63ba6eb6-0e8b-486d-927a-2b031f424cfa],
[j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1613/workflows/9d4f6eac-8bb6-45d4-8e5d-fae277372665]|
> Concurrent equivalent schema updates lead to unresolved disagreement
> --------------------------------------------------------------------
>
> Key: CASSANDRA-19578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19578
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
> Reporter: Chris Lohfink
> Priority: Normal
> Fix For: 4.1.x, 5.0.x
>
>
> As part of CASSANDRA-17819 a check for empty schema changes was added to the
> updateSchema. This only looks at the _logical_ schema difference of the
> schemas, but the changes made to the system_schema keyspace are the ones that
> actually are involved in the digest.
> If two nodes issue the same CREATE statement the difference from the
> keyspace.diff would be empty but the timestamps on the mutations would be
> different, leading to a pseudo schema disagreement which will never resolve
> until resetlocalschema or nodes being bounced.
> Only impacts 4.1
> test and fix :
> https://github.com/clohfink/cassandra/commit/ba915f839089006ac6d08494ef19dc010bcd6411
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
