[
https://issues.apache.org/jira/browse/CASSANDRA-19632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845373#comment-17845373
]
Brandon Williams commented on CASSANDRA-19632:
----------------------------------------------
There are nearly 500 instances of trace logging in the code base, wrapping them
is at the least significant delta, so this is trivial in thought but less so in
execution. Making changes "across the codebase" this close to release doesn't
seem like prudent near-release behavior to me.
This may improve stability, but probably not in an empirically measurable way,
and I don't know of trace logging (when not enabled) causing any instability
now. The risk versus reward calculation just doesn't look equitable for 5.0.0.
> wrap tracing logs in isTraceEnabled across the codebase
> -------------------------------------------------------
>
> Key: CASSANDRA-19632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19632
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> Our usage of logger.isTraceEnabled across the codebase is inconsistent. This
> would also fix issues similar in e.g. CASSANDRA-19429 as [~rustyrazorblade]
> suggested.
> We should fix this at least in trunk and 5.0 (not critical though) and
> probably come up with a checkstyle rule to prevent not calling isTraceEnabled
> while logging with TRACE level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
