[ https://issues.apache.org/jira/browse/CASSANDRA-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686728#comment-13686728 ]
Sylvain Lebresne commented on CASSANDRA-5149: --------------------------------------------- bq. In IDiskAtomFilter.collectReducedColumns() timestamp and gcbefore are sometimes unrelated Right, forgot about that. Last version lgtm, +1. A few optional minor nits for the commit: * In CounterColumn.reconcile (and CounterMutation and ... in fact), we don't support expiring columns in counter tables so it's ok to just use say Long.MIN_VALUE (which a comment why). * the comment inside DeletedColumn.isMarkedForDelete is obsolete (it's more confusing that helpful now :)). > Respect slice count even if column expire mid-request > ----------------------------------------------------- > > Key: CASSANDRA-5149 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5149 > Project: Cassandra > Issue Type: Bug > Affects Versions: 0.7.0 > Reporter: Sylvain Lebresne > Assignee: Aleksey Yeschenko > Fix For: 2.0 > > > This is a follow-up of CASSANDRA-5099. > If a column expire just while a slice query is performed, it is possible for > replicas to count said column as live but to have the coordinator seeing it > as dead when building the final result. The effect that the query might > return strictly less columns that the requested slice count even though there > is some live columns matching the slice predicate but not returned in the > result. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira