[ 
https://issues.apache.org/jira/browse/CASSANDRA-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686732#comment-13686732
 ] 

Aleksey Yeschenko edited comment on CASSANDRA-5149 at 6/18/13 2:03 PM:
-----------------------------------------------------------------------

Thanks!

bq. In CounterColumn.reconcile (and CounterMutation and ... in fact), we don't 
support expiring columns in counter tables so it's ok to just use say 
Long.MIN_VALUE (which a comment why)

I know. Same with Column.getString() - it's overloaded by ExpiringColumn 
anyway. I was debating with myself what to use - Long.MIN_VALUE, 0, or just 
System.currentTimeMillis() where it doesn't matter, and went with 
System.currentTimeMillis(). Will change to Long.MIN_VALUE with a comment in 
both places.
                
      was (Author: iamaleksey):
    Thanks!

bq. In CounterColumn.reconcile (and CounterMutation and ... in fact), we don't 
support expiring columns in counter tables so it's ok to just use say 
Long.MIN_VALUE (which a comment why)

I know. Same with Column.getString() - it's overloaded by ExpiringColumn 
anyway. I was debating with myself what to use - Long.MIN_VALUE, 0, or just 
System.currentTimeMillis() where it doesn't matter, and went with 
System.currentTimeMillis(). Will change to 0 with a comment in both places.
                  
> Respect slice count even if column expire mid-request
> -----------------------------------------------------
>
>                 Key: CASSANDRA-5149
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5149
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Aleksey Yeschenko
>             Fix For: 2.0
>
>
> This is a follow-up of CASSANDRA-5099.
> If a column expire just while a slice query is performed, it is possible for 
> replicas to count said column as live but to have the coordinator seeing it 
> as dead when building the final result. The effect that the query might 
> return strictly less columns that the requested slice count even though there 
> is some live columns matching the slice predicate but not returned in the 
> result.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to