Repository: incubator-reef Updated Branches: refs/heads/master b63324137 -> de98f031e
[REEF-359] Fix violations / reconfigure check for UnusedImports check This addressed the issue by * Removing completely unused imports * Removing imports referenced only in JavaDoc and replacing these references with full type names JIRA: [REEF-359](https://issues.apache.org/jira/browse/REEF-359) Pull Request: This closes #209 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/de98f031 Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/de98f031 Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/de98f031 Branch: refs/heads/master Commit: de98f031e415ddd9237bf1537af723579e57935f Parents: b633241 Author: Mariia Mykhailova <michayl...@gmail.com> Authored: Tue Jun 9 11:15:23 2015 -0700 Committer: Markus Weimer <wei...@apache.org> Committed: Wed Jun 10 06:33:19 2015 +1000 ---------------------------------------------------------------------- .../org/apache/reef/driver/evaluator/AllocatedEvaluator.java | 5 ++--- .../org/apache/reef/driver/evaluator/EvaluatorRequest.java | 7 +++---- .../src/main/java/org/apache/reef/io/naming/NamingLookup.java | 3 +-- .../reef-common/src/main/java/org/apache/reef/task/Task.java | 4 +--- .../org/apache/reef/util/logging/LoggingScopeFactory.java | 2 -- .../java/org/apache/reef/examples/helloCLR/HelloDriver.java | 2 -- .../reef/io/data/loading/impl/EvaluatorToPartitionMapper.java | 6 ++---- .../org/apache/reef/io/data/loading/impl/NumberedSplit.java | 4 +--- .../io/network/group/api/driver/CommunicationGroupDriver.java | 3 +-- .../io/network/group/impl/GroupCommunicationMessageCodec.java | 3 +-- .../java/org/apache/reef/io/network/impl/NSConnection.java | 1 - .../naming/serialization/NamingLookupResponseCodec.java | 3 +-- .../naming/serialization/NamingRegisterRequestCodec.java | 3 +-- .../naming/serialization/NamingUnregisterRequestCodec.java | 3 +-- .../java/org/apache/reef/runtime/local/client/FileSet.java | 1 - .../reef/runtime/local/client/LocalJobSubmissionHandler.java | 1 - .../reef/runtime/local/client/LocalRuntimeConfiguration.java | 1 - .../org/apache/reef/runtime/local/driver/ResourceManager.java | 3 --- .../org/apache/reef/runtime/mesos/MesosClasspathProvider.java | 1 - .../reef/runtime/yarn/client/YarnClientConfiguration.java | 1 - .../java/org/apache/reef/tang/JavaConfigurationBuilder.java | 3 +-- .../main/java/org/apache/reef/tang/formats/CommandLine.java | 1 - .../java/org/apache/reef/tang/util/ReflectionUtilities.java | 3 +-- .../reef/wake/remote/impl/RemoteSenderEventHandler.java | 1 - .../apache/reef/wake/remote/ports/RangeTcpPortProvider.java | 3 --- .../org/apache/reef/wake/remote/ports/TcpPortProvider.java | 1 - .../src/main/java/org/apache/reef/webserver/HttpServer.java | 2 -- .../java/org/apache/reef/webserver/ParsedHttpRequest.java | 3 +-- 28 files changed, 18 insertions(+), 56 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java index 7a3bf7d..48dbfdd 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java @@ -28,7 +28,6 @@ import org.apache.reef.io.naming.Identifiable; import org.apache.reef.tang.Configuration; import java.io.File; -import java.io.IOException; /** * Represents an Evaluator that is allocated, but is not running yet. @@ -43,7 +42,7 @@ public interface AllocatedEvaluator * Puts the given file into the working directory of the Evaluator. * * @param file the file to be copied - * @throws IOException if the copy fails. + * @throws java.io.IOException if the copy fails. */ void addFile(final File file); @@ -51,7 +50,7 @@ public interface AllocatedEvaluator * Puts the given file into the working directory of the Evaluator and adds it to its classpath. * * @param file the file to be copied - * @throws IOException if the copy fails. + * @throws java.io.IOException if the copy fails. */ void addLibrary(final File file); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java index 9bc185f..72b6e64 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java @@ -21,7 +21,6 @@ package org.apache.reef.driver.evaluator; import org.apache.reef.annotations.Provided; import org.apache.reef.annotations.audience.DriverSide; import org.apache.reef.annotations.audience.Public; -import org.apache.reef.driver.catalog.NodeDescriptor; import org.apache.reef.driver.catalog.ResourceCatalog; /** @@ -81,10 +80,10 @@ public final class EvaluatorRequest { } /** - * Access the {@link NodeDescriptor} used as the template for this + * Access the {@link org.apache.reef.driver.catalog.NodeDescriptor} used as the template for this * {@link EvaluatorRequest}. * - * @return the {@link NodeDescriptor} used as the template for this + * @return the {@link org.apache.reef.driver.catalog.NodeDescriptor} used as the template for this * {@link EvaluatorRequest}. */ public final ResourceCatalog.Descriptor getDescriptor() { @@ -157,7 +156,7 @@ public final class EvaluatorRequest { /** * Pre-fill this {@link EvaluatorRequest} from the given - * {@link NodeDescriptor}. Any value not changed in subsequent calls to + * {@link org.apache.reef.driver.catalog.NodeDescriptor}. Any value not changed in subsequent calls to * this Builder will be taken from the given descriptor. * * @param rd the descriptor used to pre-fill this request. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java index 2a70315..d6a05a8 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java @@ -21,7 +21,6 @@ package org.apache.reef.io.naming; import org.apache.reef.annotations.audience.Public; import org.apache.reef.wake.Identifier; -import java.io.IOException; import java.net.InetSocketAddress; /** @@ -36,7 +35,7 @@ public interface NamingLookup { * * @param id * @return - * @throws IOException + * @throws java.io.IOException */ public InetSocketAddress lookup(final Identifier id) throws Exception; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java index 4ac3662..fd0bc58 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java @@ -21,15 +21,13 @@ package org.apache.reef.task; import org.apache.reef.annotations.audience.Public; import org.apache.reef.annotations.audience.TaskSide; -import java.util.concurrent.Callable; - /** * The interface for Tasks. * <p/> * This interface is to be implemented for Tasks. * <p/> * The main entry point for a Task is the call() method inherited from - * {@link Callable}. The REEF Evaluator will call this method in order to run + * {@link java.util.concurrent.Callable}. The REEF Evaluator will call this method in order to run * the Task. The byte[] returned by it will be pushed to the Job Driver. */ @TaskSide http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java index 5520118..ba5ce1f 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java @@ -19,8 +19,6 @@ package org.apache.reef.util.logging; -import org.apache.reef.tang.JavaConfigurationBuilder; -import org.apache.reef.tang.Tang; import org.apache.reef.tang.annotations.Parameter; import org.apache.reef.wake.time.event.StartTime; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java index 7b76f46..33f60a3 100644 --- a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java +++ b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java @@ -23,10 +23,8 @@ import org.apache.reef.driver.evaluator.AllocatedEvaluator; import org.apache.reef.driver.evaluator.CLRProcessFactory; import org.apache.reef.driver.evaluator.EvaluatorRequest; import org.apache.reef.driver.evaluator.EvaluatorRequestor; -import org.apache.reef.driver.evaluator.EvaluatorType; import org.apache.reef.driver.task.TaskConfiguration; import org.apache.reef.examples.hello.HelloTask; -import org.apache.reef.driver.evaluator.CLRProcess; import org.apache.reef.tang.ClassHierarchy; import org.apache.reef.tang.Configuration; import org.apache.reef.tang.ConfigurationBuilder; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorToPartitionMapper.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorToPartitionMapper.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorToPartitionMapper.java index 639f032..e7d17e1 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorToPartitionMapper.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorToPartitionMapper.java @@ -18,10 +18,8 @@ */ package org.apache.reef.io.data.loading.impl; -import org.apache.hadoop.mapred.InputFormat; import org.apache.hadoop.mapred.InputSplit; import org.apache.reef.annotations.audience.DriverSide; -import org.apache.reef.io.data.loading.api.DataLoadingService; import java.io.IOException; import java.util.Map; @@ -36,8 +34,8 @@ import java.util.logging.Logger; * Class that tracks the mapping between * evaluators & the data partition assigned * to those evaluators. Its part of the - * implementation of a {@link DataLoadingService} - * that uses the Hadoop {@link InputFormat} to + * implementation of a {@link org.apache.reef.io.data.loading.api.DataLoadingService} + * that uses the Hadoop {@link org.apache.hadoop.mapred.InputFormat} to * partition the data and request resources * accordingly * <p/> http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/NumberedSplit.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/NumberedSplit.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/NumberedSplit.java index 9a10a12..9efa127 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/NumberedSplit.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/NumberedSplit.java @@ -18,12 +18,10 @@ */ package org.apache.reef.io.data.loading.impl; -import org.apache.hadoop.mapred.InputSplit; - /** * A tuple of an object of type E and an integer index. * Used inside {@link EvaluatorToPartitionMapper} to - * mark the partitions associated with each {@link InputSplit} + * mark the partitions associated with each {@link org.apache.hadoop.mapred.InputSplit} * * @param <E> */ http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java index 887ea52..3b9194c 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java @@ -19,7 +19,6 @@ package org.apache.reef.io.network.group.api.driver; import org.apache.reef.annotations.audience.DriverSide; -import org.apache.reef.io.network.group.api.task.GroupCommClient; import org.apache.reef.io.network.group.impl.config.BroadcastOperatorSpec; import org.apache.reef.io.network.group.impl.config.ReduceOperatorSpec; import org.apache.reef.tang.Configuration; @@ -69,7 +68,7 @@ public interface CommunicationGroupDriver { * configuration passed in as 'taskConf' and makes the * current communication group and the operators configured * on it available on the Task side. Provides for injection - * of {@link GroupCommClient} + * of {@link org.apache.reef.io.network.group.api.task.GroupCommClient} * * @param taskConf * @return http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/GroupCommunicationMessageCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/GroupCommunicationMessageCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/GroupCommunicationMessageCodec.java index 1d8a2a0..2468619 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/GroupCommunicationMessageCodec.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/GroupCommunicationMessageCodec.java @@ -20,14 +20,13 @@ package org.apache.reef.io.network.group.impl; import org.apache.reef.io.network.impl.StreamingCodec; -import org.apache.reef.io.network.proto.ReefNetworkGroupCommProtos.GroupCommMessage; import org.apache.reef.io.network.proto.ReefNetworkGroupCommProtos.GroupCommMessage.Type; import javax.inject.Inject; import java.io.*; /** - * Codec for {@link GroupCommMessage}. + * Codec for {@link org.apache.reef.io.network.proto.ReefNetworkGroupCommProtos.GroupCommMessage}. */ public class GroupCommunicationMessageCodec implements StreamingCodec<GroupCommunicationMessage> { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java index bbb3620..b5fa9e3 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NSConnection.java @@ -26,7 +26,6 @@ import org.apache.reef.wake.remote.Codec; import org.apache.reef.wake.remote.transport.Link; import org.apache.reef.wake.remote.transport.LinkListener; -import java.io.IOException; import java.net.InetSocketAddress; import java.net.SocketAddress; import java.util.logging.Level; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java index d863b69..a9787af 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingLookupResponseCodec.java @@ -22,7 +22,6 @@ import org.apache.reef.io.naming.NameAssignment; import org.apache.reef.io.network.naming.NameAssignmentTuple; import org.apache.reef.io.network.naming.avro.AvroNamingAssignment; import org.apache.reef.io.network.naming.avro.AvroNamingLookupResponse; -import org.apache.reef.io.network.naming.exception.NamingRuntimeException; import org.apache.reef.wake.IdentifierFactory; import org.apache.reef.wake.remote.Codec; @@ -74,7 +73,7 @@ public final class NamingLookupResponseCodec implements Codec<NamingLookupRespon * * @param buf the byte array * @return a naming lookup response - * @throws NamingRuntimeException + * @throws org.apache.reef.io.network.naming.exception.NamingRuntimeException */ @Override public NamingLookupResponse decode(final byte[] buf) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java index 1b62bd9..ee1c848 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingRegisterRequestCodec.java @@ -20,7 +20,6 @@ package org.apache.reef.io.network.naming.serialization; import org.apache.reef.io.network.naming.NameAssignmentTuple; import org.apache.reef.io.network.naming.avro.AvroNamingRegisterRequest; -import org.apache.reef.io.network.naming.exception.NamingRuntimeException; import org.apache.reef.wake.IdentifierFactory; import org.apache.reef.wake.remote.Codec; @@ -63,7 +62,7 @@ public class NamingRegisterRequestCodec implements Codec<NamingRegisterRequest> * * @param buf the byte array * @return a naming registration request - * @throws NamingRuntimeException + * @throws org.apache.reef.io.network.naming.exception.NamingRuntimeException */ @Override public NamingRegisterRequest decode(byte[] buf) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java index f278c55..cf0858a 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/NamingUnregisterRequestCodec.java @@ -19,7 +19,6 @@ package org.apache.reef.io.network.naming.serialization; import org.apache.reef.io.network.naming.avro.AvroNamingUnRegisterRequest; -import org.apache.reef.io.network.naming.exception.NamingRuntimeException; import org.apache.reef.wake.IdentifierFactory; import org.apache.reef.wake.remote.Codec; @@ -61,7 +60,7 @@ public final class NamingUnregisterRequestCodec implements Codec<NamingUnregiste * * @param buf the byte array * @return a naming un-registration request - * @throws NamingRuntimeException + * @throws org.apache.reef.io.network.naming.exception.NamingRuntimeException */ @Override public NamingUnregisterRequest decode(byte[] buf) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java index e27d0a2..a00c4a5 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java @@ -23,7 +23,6 @@ import org.apache.reef.tang.formats.OptionalParameter; import java.io.File; import java.io.IOException; -import java.nio.file.CopyOption; import java.nio.file.Files; import java.util.HashSet; import java.util.Set; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java index fbf2bf7..7e20d32 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java @@ -22,7 +22,6 @@ import org.apache.reef.annotations.audience.ClientSide; import org.apache.reef.annotations.audience.Private; import org.apache.reef.runtime.common.client.api.JobSubmissionEvent; import org.apache.reef.runtime.common.client.api.JobSubmissionHandler; -import org.apache.reef.runtime.common.files.ClasspathProvider; import org.apache.reef.runtime.common.files.REEFFileNames; import org.apache.reef.runtime.local.client.parameters.RootFolder; import org.apache.reef.tang.Configuration; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalRuntimeConfiguration.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalRuntimeConfiguration.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalRuntimeConfiguration.java index 9a882cf..57ae932 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalRuntimeConfiguration.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalRuntimeConfiguration.java @@ -31,7 +31,6 @@ import org.apache.reef.tang.formats.ConfigurationModule; import org.apache.reef.tang.formats.ConfigurationModuleBuilder; import org.apache.reef.tang.formats.OptionalImpl; import org.apache.reef.tang.formats.OptionalParameter; -import org.apache.reef.wake.remote.address.LocalAddressProvider; import java.util.concurrent.ExecutorService; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java index a09ff04..b3979f7 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java @@ -32,9 +32,6 @@ import org.apache.reef.runtime.common.driver.resourcemanager.RuntimeStatusEventI import org.apache.reef.runtime.common.files.ClasspathProvider; import org.apache.reef.runtime.common.files.FileResource; import org.apache.reef.runtime.common.files.REEFFileNames; -import org.apache.reef.runtime.common.launch.CLRLaunchCommandBuilder; -import org.apache.reef.runtime.common.launch.JavaLaunchCommandBuilder; -import org.apache.reef.runtime.common.launch.LaunchCommandBuilder; import org.apache.reef.runtime.common.parameters.JVMHeapSlack; import org.apache.reef.runtime.common.utils.RemoteManager; import org.apache.reef.runtime.local.client.parameters.DefaultMemorySize; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/MesosClasspathProvider.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/MesosClasspathProvider.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/MesosClasspathProvider.java index 773de03..3065210 100644 --- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/MesosClasspathProvider.java +++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/MesosClasspathProvider.java @@ -24,7 +24,6 @@ import org.apache.reef.runtime.common.files.RuntimeClasspathProvider; import javax.inject.Inject; import java.util.Arrays; import java.util.List; -import java.util.logging.Logger; /** * Access to the classpath according to the REEF file system standard. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnClientConfiguration.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnClientConfiguration.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnClientConfiguration.java index 15f7435..8731aa4 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnClientConfiguration.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnClientConfiguration.java @@ -35,7 +35,6 @@ import org.apache.reef.tang.formats.ConfigurationModuleBuilder; import org.apache.reef.tang.formats.OptionalImpl; import org.apache.reef.tang.formats.OptionalParameter; import org.apache.reef.util.logging.LoggingSetup; -import org.apache.reef.wake.remote.address.LocalAddressProvider; /** * A ConfigurationModule for the YARN resourcemanager. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java index 202ba1a..75b10b1 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java @@ -21,7 +21,6 @@ package org.apache.reef.tang; import org.apache.reef.tang.annotations.Name; import org.apache.reef.tang.exceptions.BindException; -import org.apache.reef.tang.exceptions.NameResolutionException; import java.util.List; import java.util.Set; @@ -67,7 +66,7 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder { * @param name The dummy class that serves as the name of this parameter. * @param value A string representing the value of the parameter. Reef must know * how to parse the parameter's type. - * @throws NameResolutionException + * @throws org.apache.reef.tang.exceptions.NameResolutionException */ public JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<?>> name, String value) throws BindException; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java index 649aa8e..a20719d 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java @@ -21,7 +21,6 @@ package org.apache.reef.tang.formats; import org.apache.commons.cli.*; import org.apache.reef.tang.Configuration; import org.apache.reef.tang.ConfigurationBuilder; -import org.apache.reef.tang.JavaConfigurationBuilder; import org.apache.reef.tang.Tang; import org.apache.reef.tang.annotations.Name; import org.apache.reef.tang.exceptions.BindException; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java index c81ae55..4bff7f4 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java @@ -20,7 +20,6 @@ package org.apache.reef.tang.util; import org.apache.reef.tang.annotations.Name; import org.apache.reef.tang.annotations.NamedParameter; -import org.apache.reef.tang.exceptions.BindException; import org.apache.reef.tang.exceptions.ClassHierarchyException; import javax.inject.Inject; @@ -285,7 +284,7 @@ public class ReflectionUtilities { /** * @param clazz * @return T if clazz implements Name<T>, null otherwise - * @throws BindException If clazz's definition incorrectly uses Name or @NamedParameter + * @throws org.apache.reef.tang.exceptions.BindException If clazz's definition incorrectly uses Name or @NamedParameter */ static public Type getNamedParameterTargetOrNull(Class<?> clazz) throws ClassHierarchyException { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java index 7de000a..394c310 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/RemoteSenderEventHandler.java @@ -25,7 +25,6 @@ import org.apache.reef.wake.remote.transport.Link; import org.apache.reef.wake.remote.transport.Transport; import org.apache.reef.wake.remote.transport.netty.LoggingLinkListener; -import java.io.IOException; import java.net.SocketAddress; import java.util.concurrent.*; import java.util.concurrent.atomic.AtomicReference; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RangeTcpPortProvider.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RangeTcpPortProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RangeTcpPortProvider.java index a68bec7..48fb163 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RangeTcpPortProvider.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/RangeTcpPortProvider.java @@ -19,9 +19,6 @@ package org.apache.reef.wake.remote.ports; -import org.apache.reef.tang.Configuration; -import org.apache.reef.tang.ConfigurationProvider; -import org.apache.reef.tang.Tang; import org.apache.reef.tang.annotations.Parameter; import org.apache.reef.wake.remote.ports.parameters.TcpPortRangeBegin; import org.apache.reef.wake.remote.ports.parameters.TcpPortRangeCount; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/TcpPortProvider.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/TcpPortProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/TcpPortProvider.java index 51a8f6e..0a945e2 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/TcpPortProvider.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/TcpPortProvider.java @@ -18,7 +18,6 @@ */ package org.apache.reef.wake.remote.ports; -import org.apache.reef.tang.Configuration; import org.apache.reef.tang.annotations.DefaultImplementation; import java.util.Iterator; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java index 4bed6c5..73e1705 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java @@ -18,8 +18,6 @@ */ package org.apache.reef.webserver; -import org.apache.reef.tang.annotations.DefaultImplementation; - /** * HttpServer interface. */ http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/de98f031/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ParsedHttpRequest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ParsedHttpRequest.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ParsedHttpRequest.java index 6001ddb..7ad867a 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ParsedHttpRequest.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/ParsedHttpRequest.java @@ -18,7 +18,6 @@ */ package org.apache.reef.webserver; -import javax.servlet.ServletException; import javax.servlet.http.HttpServletRequest; import java.io.IOException; import java.net.URLDecoder; @@ -46,7 +45,7 @@ public final class ParsedHttpRequest { * * @param request * @throws IOException - * @throws ServletException + * @throws javax.servlet.ServletException */ public ParsedHttpRequest(final HttpServletRequest request) throws IOException { this.pathInfo = request.getPathInfo() != null ? request.getPathInfo() : "";
