Repository: spark Updated Branches: refs/heads/branch-2.1 42229430f -> 09f70f5fd
[SPARK-25089][R] removing lintr checks for 2.1 ## What changes were proposed in this pull request? since 2.1 will be EOLed some time in the not too distant future, and we'll be moving the builds from centos to ubuntu, i think it's fine to disable R linting rather than going down the rabbit hole of trying to fix this stuff. ## How was this patch tested? the build system will test this Closes #22073 from shaneknapp/removing-lintr. Authored-by: shane knapp <incompl...@gmail.com> Signed-off-by: Sean Owen <sro...@gmail.com> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/09f70f5f Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/09f70f5f Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/09f70f5f Branch: refs/heads/branch-2.1 Commit: 09f70f5fd681dd3f38b7d9e6514f1fd63703e7f1 Parents: 4222943 Author: shane knapp <incompl...@gmail.com> Authored: Fri Aug 10 18:06:54 2018 -0500 Committer: Sean Owen <sro...@gmail.com> Committed: Fri Aug 10 18:06:54 2018 -0500 ---------------------------------------------------------------------- dev/run-tests.py | 14 -------------- 1 file changed, 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/09f70f5f/dev/run-tests.py ---------------------------------------------------------------------- diff --git a/dev/run-tests.py b/dev/run-tests.py index f24aac9..8ff8f51 100755 --- a/dev/run-tests.py +++ b/dev/run-tests.py @@ -212,18 +212,6 @@ def run_python_style_checks(): run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")]) -def run_sparkr_style_checks(): - set_title_and_block("Running R style checks", "BLOCK_R_STYLE") - - if which("R"): - # R style check should be executed after `install-dev.sh`. - # Since warnings about `no visible global function definition` appear - # without the installation. SEE ALSO: SPARK-9121. - run_cmd([os.path.join(SPARK_HOME, "dev", "lint-r")]) - else: - print("Ignoring SparkR style check as R was not found in PATH") - - def build_spark_documentation(): set_title_and_block("Building Spark Documentation", "BLOCK_DOCUMENTATION") os.environ["PRODUCTION"] = "1 jekyll build" @@ -561,8 +549,6 @@ def main(): pass if not changed_files or any(f.endswith(".py") for f in changed_files): run_python_style_checks() - if not changed_files or any(f.endswith(".R") for f in changed_files): - run_sparkr_style_checks() # determine if docs were changed and if we're inside the amplab environment # note - the below commented out until *all* Jenkins workers can get `jekyll` installed --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
