This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 974313994a05 [SPARK-45835][INFRA] Make gitHub labeler more accurate
and remove outdated comments
974313994a05 is described below
commit 974313994a0594fde7b424e569febed89cafd9ca
Author: panbingkun <pbk1...@gmail.com>
AuthorDate: Wed Nov 8 19:22:13 2023 -0800
[SPARK-45835][INFRA] Make gitHub labeler more accurate and remove outdated
comments
### What changes were proposed in this pull request?
The pr aims to make gitHub labeler more accurate and remove outdated
comments.
### Why are the changes needed?
The functions mentioned in the comments have been released in the latest
version of Github Action labeler.
https://github.com/actions/labeler/issues/111
https://github.com/actions/labeler/issues/111#issuecomment-1345989028
<img width="906" alt="image"
src="https://github.com/apache/spark/assets/15246973/75f87a07-f0af-41f4-801b-13545e966587";>
According to the description of the original PR
(https://github.com/apache/spark/pull/30244/files), after 'any/all' is released
in the official version of `Github Action labeler`, we need to make subsequent
updates to better identify the code `label`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Continuous manual observation is required.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #43716 from panbingkun/SPARK-45835.
Authored-by: panbingkun <pbk1...@gmail.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
.github/labeler.yml | 40 +++++-----------------------------------
.github/workflows/labeler.yml | 13 -------------
2 files changed, 5 insertions(+), 48 deletions(-)
diff --git a/.github/labeler.yml b/.github/labeler.yml
index f21b90d460fb..fc69733f4b66 100644
--- a/.github/labeler.yml
+++ b/.github/labeler.yml
@@ -17,23 +17,6 @@
# under the License.
#
-#
-# Pull Request Labeler Github Action Configuration:
https://github.com/marketplace/actions/labeler
-#
-# Note that we currently cannot use the negatioon operator (i.e. `!`) for
miniglob matches as they
-# would match any file that doesn't touch them. What's needed is the concept
of `any `, which takes a
-# list of constraints / globs and then matches all of the constraints for
either `any` of the files or
-# `all` of the files in the change set.
-#
-# However, `any`/`all` are not supported in a released version and testing off
of the `main` branch
-# resulted in some other errors when testing.
-#
-# An issue has been opened upstream requesting that a release be cut that has
support for all/any:
-# - https://github.com/actions/labeler/issues/111
-#
-# While we wait for this issue to be handled upstream, we can remove
-# the negated / `!` matches for now and at least have labels again.
-#
INFRA:
- ".github/**/*"
- "appveyor.yml"
@@ -45,9 +28,7 @@ INFRA:
- "dev/merge_spark_pr.py"
- "dev/run-tests-jenkins*"
BUILD:
- # Can be supported when a stable release with correct all/any is released
- #- any: ['dev/**/*', '!dev/merge_spark_pr.py', '!dev/.rat-excludes']
- - "dev/**/*"
+ - any: ['dev/**/*', '!dev/merge_spark_pr.py', '!dev/run-tests-jenkins*']
- "build/**/*"
- "project/**/*"
- "assembly/**/*"
@@ -55,22 +36,16 @@ BUILD:
- "bin/docker-image-tool.sh"
- "bin/find-spark-home*"
- "scalastyle-config.xml"
- # These can be added in the above `any` clause (and the /dev/**/* glob
removed) when
- # `any`/`all` support is released
- # - "!dev/merge_spark_pr.py"
- # - "!dev/run-tests-jenkins*"
- # - "!dev/.rat-excludes"
DOCS:
- "docs/**/*"
- "**/README.md"
- "**/CONTRIBUTING.md"
+ - "python/docs/**/*"
EXAMPLES:
- "examples/**/*"
- "bin/run-example*"
-# CORE needs to be updated when all/any are released upstream.
CORE:
- # - any: ["core/**/*", "!**/*UI.scala", "!**/ui/**/*"] # If any file matches
all of the globs defined in the list started by `any`, label is applied.
- - "core/**/*"
+ - any: ["core/**/*", "!**/*UI.scala", "!**/ui/**/*"]
- "common/kvstore/**/*"
- "common/network-common/**/*"
- "common/network-shuffle/**/*"
@@ -82,12 +57,8 @@ SPARK SHELL:
- "repl/**/*"
- "bin/spark-shell*"
SQL:
-#- any: ["**/sql/**/*", "!python/pyspark/sql/avro/**/*",
"!python/pyspark/sql/streaming/**/*",
"!python/pyspark/sql/tests/streaming/test_streaming.py"]
- - "**/sql/**/*"
+ - any: ["**/sql/**/*", "!python/pyspark/sql/avro/**/*",
"!python/pyspark/sql/streaming/**/*",
"!python/pyspark/sql/tests/streaming/test_streaming*.py"]
- "common/unsafe/**/*"
- #- "!python/pyspark/sql/avro/**/*"
- #- "!python/pyspark/sql/streaming/**/*"
- #- "!python/pyspark/sql/tests/streaming/test_streaming.py"
- "bin/spark-sql*"
- "bin/beeline*"
- "sbin/*thriftserver*.sh"
@@ -123,7 +94,7 @@ STRUCTURED STREAMING:
- "**/sql/**/streaming/**/*"
- "connector/kafka-0-10-sql/**/*"
- "python/pyspark/sql/streaming/**/*"
- - "python/pyspark/sql/tests/streaming/test_streaming.py"
+ - "python/pyspark/sql/tests/streaming/test_streaming*.py"
- "**/*streaming.R"
PYTHON:
- "bin/pyspark*"
@@ -148,7 +119,6 @@ DEPLOY:
- "sbin/**/*"
CONNECT:
- "connector/connect/**/*"
- - "**/sql/sparkconnect/**/*"
- "python/pyspark/sql/**/connect/**/*"
- "python/pyspark/ml/**/connect/**/*"
PROTOBUF:
diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml
index c6b6e65bc9fe..b55d28e5a640 100644
--- a/.github/workflows/labeler.yml
+++ b/.github/workflows/labeler.yml
@@ -34,19 +34,6 @@ jobs:
contents: read
pull-requests: write
steps:
- # In order to get back the negated matches like in the old config,
- # we need the actinons/labeler concept of `all` and `any` which matches
- # all of the given constraints / glob patterns for either `all`
- # files or `any` file in the change set.
- #
- # Github issue which requests a timeline for a release with any/all
support:
- # - https://github.com/actions/labeler/issues/111
- # This issue also references the issue that mentioned that any/all are only
- # supported on main branch (previously called master):
- # - https://github.com/actions/labeler/issues/73#issuecomment-639034278
- #
- # However, these are not in a published release and the current `main`
branch
- # has some issues upon testing.
- uses: actions/labeler@v4
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
