This is an automated email from the ASF dual-hosted git repository.

lukaszlenart pushed a commit to branch struts-2-5-x
in repository https://gitbox.apache.org/repos/asf/struts.git


The following commit(s) were added to refs/heads/struts-2-5-x by this push:
     new 4786fba  Minor change to fix WW-5072 (single file upload failure): - 
Add action-local method to get upload file size. - Change file upload 
validation to use new method.
     new e46e662  Merge pull request #411 from 
JCgH4164838Gh792C124B5/WW-5072_fix
4786fba is described below

commit 4786fba0d74b6562fe3053391fab474cedd64e9c
Author: JCgH4164838Gh792C124B5 
<43964333+jcgh4164838gh792c12...@users.noreply.github.com>
AuthorDate: Sat May 2 17:47:17 2020 -0400

    Minor change to fix WW-5072 (single file upload failure):
    - Add action-local method to get upload file size.
    - Change file upload validation to use new method.
---
 .../org/apache/struts2/showcase/fileupload/FileUploadAction.java  | 8 ++++++++
 .../struts2/showcase/fileupload/FileUploadAction-validation.xml   | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git 
a/apps/showcase/src/main/java/org/apache/struts2/showcase/fileupload/FileUploadAction.java
 
b/apps/showcase/src/main/java/org/apache/struts2/showcase/fileupload/FileUploadAction.java
index 6005306..ed8a11b 100644
--- 
a/apps/showcase/src/main/java/org/apache/struts2/showcase/fileupload/FileUploadAction.java
+++ 
b/apps/showcase/src/main/java/org/apache/struts2/showcase/fileupload/FileUploadAction.java
@@ -84,4 +84,12 @@ public class FileUploadAction extends ActionSupport {
        public void setCaption(String caption) {
                this.caption = caption;
        }
+
+        public long getUploadSize() {
+            if (upload != null) {
+                return upload.length();
+            } else {
+                return 0;
+            }
+        }
 }
diff --git 
a/apps/showcase/src/main/resources/org/apache/struts2/showcase/fileupload/FileUploadAction-validation.xml
 
b/apps/showcase/src/main/resources/org/apache/struts2/showcase/fileupload/FileUploadAction-validation.xml
index df2dd55..cfd4178 100644
--- 
a/apps/showcase/src/main/resources/org/apache/struts2/showcase/fileupload/FileUploadAction-validation.xml
+++ 
b/apps/showcase/src/main/resources/org/apache/struts2/showcase/fileupload/FileUploadAction-validation.xml
@@ -26,7 +26,7 @@
 <validators>
        <field name="upload">
                <field-validator type="fieldexpression">
-                       <param name="expression"><![CDATA[upload.length() > 
0]]></param>
+                       <param name="expression"><![CDATA[getUploadSize() > 
0]]></param>
                        <message>File cannot be empty</message>
                </field-validator>
        </field>

Reply via email to