Author: gstein Date: Sun Oct 22 05:05:50 2023 New Revision: 1913186 URL: http://svn.apache.org/viewvc?rev=1913186&view=rev Log: Start removing lambda/strings and move to CHANGE_ACTION values.
* tools/hook-scripts/mailer/mailer.py: (generate_list): pass a CHANGE_ACTION value, rather than a func (_gather_paths): take an action value, rather than a filter function Modified: subversion/trunk/tools/hook-scripts/mailer/mailer.py Modified: subversion/trunk/tools/hook-scripts/mailer/mailer.py URL: http://svn.apache.org/viewvc/subversion/trunk/tools/hook-scripts/mailer/mailer.py?rev=1913186&r1=1913185&r2=1913186&view=diff ============================================================================== --- subversion/trunk/tools/hook-scripts/mailer/mailer.py (original) +++ subversion/trunk/tools/hook-scripts/mailer/mailer.py Sun Oct 22 05:05:50 2023 @@ -829,21 +829,19 @@ def generate_content(writer, cfg, repos, def generate_list(changekind, changelist, paths, in_paths): - if changekind == 'A': - selection = lambda change: change.action == svn.repos.CHANGE_ACTION_ADD - elif changekind == 'R': - selection = lambda change: change.action == svn.repos.CHANGE_ACTION_REPLACE - elif changekind == 'D': - selection = lambda change: change.action == svn.repos.CHANGE_ACTION_DELETE - elif changekind == 'M': - selection = lambda change: change.action == svn.repos.CHANGE_ACTION_MODIFY - return _gather_paths(selection, changelist, paths, in_paths) + action = { + 'A': svn.repos.CHANGE_ACTION_ADD, + 'R': svn.repos.CHANGE_ACTION_REPLACE, + 'D': svn.repos.CHANGE_ACTION_DELETE, + 'M': svn.repos.CHANGE_ACTION_MODIFY, + }.get(changekind) + return _gather_paths(action, changelist, paths, in_paths) -def _gather_paths(selection, changelist, paths, in_paths): +def _gather_paths(action, changelist, paths, in_paths): items = [ ] for path, change in changelist: - if selection(change) and (path in paths) == in_paths: + if change.action == action and (path in paths) == in_paths: item = _data( path=path, is_dir=change.item_kind == svn.core.svn_node_dir,