martin-g commented on code in PR #861:
URL: https://github.com/apache/wicket/pull/861#discussion_r1595479754
##########
wicket-core/src/main/java/org/apache/wicket/page/DefaultPageLockManager.java:
##########
@@ -222,3 +227,12 @@ Supplier<ConcurrentMap<Integer,
PageAccessSynchronizer.PageLock>> getLocks()
return locks;
}
}
+
+class PageLockedException extends Exception
+{
+ PageLockedException(Thread previousThread, int pageId)
Review Comment:
```suggestion
PageLockedException(Thread pageHoldingThread, int pageId)
```
##########
wicket-core/src/main/java/org/apache/wicket/page/DefaultPageLockManager.java:
##########
@@ -133,9 +133,10 @@ public void lockPage(int pageId) throws
CouldNotLockPageException
}
else
{
+ final String previousThreadName = previous != null ?
previous.getThread().getName() : "N/A";
+ final Thread previousThread = previous != null ?
previous.getThread() : null;
Review Comment:
nit: swap these two lines and simplify the latter to: `final String
previousThreadName = previousThread != null ? previousThread.getName() : "N/A";`
##########
wicket-core/src/main/java/org/apache/wicket/page/DefaultPageLockManager.java:
##########
@@ -222,3 +227,12 @@ Supplier<ConcurrentMap<Integer,
PageAccessSynchronizer.PageLock>> getLocks()
return locks;
}
}
+
+class PageLockedException extends Exception
Review Comment:
```suggestion
static class PageLockedException extends Exception
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
