steveloughran commented on code in PR #6617:
URL: https://github.com/apache/hadoop/pull/6617#discussion_r1572728278
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java:
##########
@@ -141,9 +145,11 @@ public static <T> List<T> awaitFuture(final
Collection<Future<T>> collection)
}
return results;
} catch (InterruptedException e) {
+ LOG.error("Execution of future interrupted ", e);
Review Comment:
lets make these a debug() and let the caller handle the the rest.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java:
##########
@@ -141,9 +145,11 @@ public static <T> List<T> awaitFuture(final
Collection<Future<T>> collection)
}
return results;
} catch (InterruptedException e) {
+ LOG.error("Execution of future interrupted ", e);
throw (InterruptedIOException) new InterruptedIOException(e.toString())
.initCause(e);
} catch (ExecutionException e) {
+ LOG.error("Execution of future failed with exception", e.getCause());
Review Comment:
log this at debug. handlers up the stack can choose what to do -it may be
harmless
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java:
##########
@@ -31,6 +32,8 @@
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
+import org.slf4j.Logger;
Review Comment:
shouldn't be in same import block as java*.
tip: you can set your IDE up for these rules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
