Hi Eric, I just update my email sources. and looked abit on the patches you are submitting. Cool to have some unittest.
Btw. I saw that EmailValidator of Commons Validator is used inside of Email.java; Does it realy make sence to validate an e-mail inside that class? shouldn't this work be done outside? eg. enter e-mail via Struts (validate it) in action.clazz passing the String to the class that is using [email] ? Just my thought. Btw. what should we do with the @author tags? since some projects of Apache/Jakarta are removing them. Regards, Matthias > -----Original Message----- > From: Eric Pugh [mailto:[EMAIL PROTECTED] > Sent: Monday, October 25, 2004 11:35 PM > Cc: Jakarta Commons Developers List > Subject: RE: [email] Dumbster failing > > > Not a problem. I appreciate your working with me on this. > I am looking > forward to getting [email] whipped into shape! > > ERi > > > -----Original Message----- > > From: Corey Scott [mailto:[EMAIL PROTECTED] > > Sent: Monday, October 25, 2004 7:21 PM > > To: [EMAIL PROTECTED] > > Cc: Jakarta Commons Developers List > > Subject: Re: [email] Dumbster failing > > > > > > Ok, I have the tests all up and running with Maven. > > > > I have also made some minor mods, based on the tests or > improving the > > input checking (this is why some of the tests are failing, > there where > > against my changes not the HEAD version.... sorry) > > > > So once we get this formatting issue sorted, I will submit > to you the > > new patch. This should raise the test coverage to 90+% for all > > (non-deprecated) classes. > > > > Thanks, > > Corey > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
