[ http://issues.apache.org/jira/browse/DIGESTER-107?page=comments#action_12437190 ] Simon Kitching commented on DIGESTER-107: -----------------------------------------
Ok, let's go with the simplest patch (no caching). I don't think the code should be catching and ignoring Exception though (there aren't any checked exceptions thrown by the enclosed block are there?). It could either call createSaxException, or just let the original exception propagate. I think catching RuntimeException, logging it then rethrowing the original exception would be my preference, as this is such an odd case a checked exception doesn't seem worthwhile. > Provide ability to capture namespace snapshots > ---------------------------------------------- > > Key: DIGESTER-107 > URL: http://issues.apache.org/jira/browse/DIGESTER-107 > Project: Commons Digester > Issue Type: Improvement > Affects Versions: Nightly Builds > Reporter: Rahul Akolkar > Attachments: DIGESTER-107-01.patch, DIGESTER-107.patch > > > Attached patch adds the capability to snapshot current namespaces at any > point during parsing. This is useful, for example, in Commons SCXML where the > value of an attribute can contain an XPath expression which needs to be > evaluated later. The testcase in the patch captures namespace snapshots for > each object created by the digester. Feedback welcome. > As an aside, does anyone mind if I bring the Digester JIRA versions up to > date? Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
