Stephen Warren wrote: > Here's an early version of the patch. It's not yet suitable for merging; > it doesn't yet do "IR learn" stuff, and I haven't tested it since the > latest CVS updates. That said, it should give an idea where I'm going if > you want to comment on it.
I'd rather you didn't return the type, it's inconsistent with the rest of the API - hand it back in a parameter and return an int for status. Other than that, I like the functionality and design of it, very nice! (Oh, minor nitpick, spacing issue on these two lines: + uint8_t *start_info_ptr; + err = GetTag("INFORMATION", in, size, start_info_ptr); The second one is spaces instead of tabs). -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel