Carl-Daniel Hailfinger wrote:
On 14.02.2008 19:15, Myles Watson wrote:This patch removes elfboot and references to ELF from v3. Since lar parses ELF, there's no need to have v3 parse ELF. The ELF files that v3 could parse should always have been a subset of the ones that lar could parse anyway.Myles Signed-off-by: Myles Watson <[EMAIL PROTECTED]>Patches which remove stuff are always very welcome. A few comments below.
... as long as they do not remove functionality that is still used.Please don't just remove this code. If you don't like to compile it in, create a config option to disable it. (There is such a config option already, so I really don't see the gain)
I say: NACK.
Why?
Because with this patch it is no longer possible to unpack a lar.
Please don't do stuff like that with levity.
Stefan
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
signature.asc
Description: OpenPGP digital signature
-- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
