Carl-Daniel Hailfinger wrote:
On 14.02.2008 21:59, Stefan Reinauer wrote:Carl-Daniel Hailfinger wrote:On 14.02.2008 19:31, Stefan Reinauer wrote:Carl-Daniel Hailfinger wrote:v3 still has many places where config variables are tested with #if in v2 style. That fails silently in v3. Fix up the most obvious ones.Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>While the patch itself is discussable, it is cosmetics and not a fix. In fact you are removing the check of the CONFIG_ variable's value, and so if for some reason someone sets a defined value to 0, THEN the code would fail silently after applying your diff. Can you please elaborate how any of the lines you touch would cause silent failure in v3?All of them. These values are Kconfig bools and if they are set, they are set to "y" and not 1.That's wrong, so the answer is indeed "none of them" as I expected. Here's an excerpt from config.h as generated by Kconfig:I stand corrected. However, the test for the #define being 1 is superfluous if the #define is a bool. New patch description: Remove superfluous checks for boolean CONFIG_* variables where we tested CONFIG_* == 1. If those variables are set, they will always be 1.
Acked-by: Stefan Reinauer <[EMAIL PROTECTED]>
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
signature.asc
Description: OpenPGP digital signature
-- coreboot mailing list [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
