* Myles Watson <[EMAIL PROTECTED]> [080215 22:33]:
> Here are my reasons:
> 1. It wasn't being used anyway.
> Unless you used lar to load the elf in, the Makefile always
> parsed the elf with -e
Yes, using ELF was broken by this badly reviewed patch.
This piece of code is just broken:
# We now parse initram as ELF, so we need PARSEELF enabled
# unconditionally.
ifeq ($(CONFIG_PAYLOAD_PREPARSE_ELF), y)
PARSEELF = -e
else
PARSEELF = -e
endif
This is kind of bad decay. It's unclean and hackish.
> 2. It duplicated code.
> There is no reason for v3 to understand ELF when lar parses it.
There are many reasons. See the list for reasons.
Don't get me wrong. Feel free to fix the config option to disable ELF
loading and feel free to use it in all your builds.
But don't just drop this stuff.
> Signed-off-by: Myles Watson <[EMAIL PROTECTED]>
NACK.
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
