Issue #456 has been updated by Thierry Laurion.
Martin Roth wrote in #note-3: > New 4.19 tarballs have been pushed, but they use the same name. I updated > the release notes stating that they had been updated. > > I looked at changing the name, but to do that, the actual release number > needs to be changed on the website. The names are tightly coupled. Since > this is still the 4.19 release, just a repack of the tarballs, the names > needed to remain the same. I felt that changing the release name would > create more long-term confusion, so at least for now, the binaries are posted > with the same name. > > I have preserved the old binaries, but moved them out of the download folder. > > Let me know if this is a satisfactory resolution. I'll mark this issue fixed > after any further discussion or lack of discussion. coreboot 4.19 and coreboot-blobs tarballs are now correct. This issue can now be closed! Thanks! ---------------------------------------- Bug #456: coreboot 4.19 tarballs have bad timestamps https://ticket.coreboot.org/issues/456#change-1419 * Author: Thierry Laurion * Status: Feedback * Priority: High * Category: infrastructure * Target version: 4.19 * Start date: 2023-02-08 * Affected versions: 4.19, master * Needs backport to: 4.19, master * Related links: Thank you for the fixes. Could you document the old and new hashes somewhere? ---------------------------------------- As reported on #coreboot channel, coreboot 4.19 tarballs contain invalid timestamps (year 1901) for all contained files. Reproducility of issue: wget https://www.coreboot.org/releases/coreboot-4.19.tar.xz user@heads-tests:/tmp/test$ ls -al coreboot-4.19.tar.xz -rw-r--r-- 1 user user 56908588 Jan 26 21:46 coreboot-4.19.tar.xz user@heads-tests:/tmp/test$ tar Jxvf coreboot-4.19.tar.xz coreboot-4.19/ coreboot-4.19/.checkpatch.conf tar: coreboot-4.19/.checkpatch.conf: implausibly old time stamp -9223372036854775808 coreboot-4.19/.clang-format tar: coreboot-4.19/.clang-format: implausibly old time stamp -9223372036854775808 coreboot-4.19/.coreboot-version tar: coreboot-4.19/.coreboot-version: implausibly old time stamp -9223372036854775808 coreboot-4.19/.crossgcc-version tar: coreboot-4.19/.crossgcc-version: implausibly old time stamp -9223372036854775808 coreboot-4.19/.editorconfig tar: coreboot-4.19/.editorconfig: implausibly old time stamp -9223372036854775808 Cause: @icon investigated and said "d05ea79e40c4 util/release/build-release: Fix style issues at least that change to the tstamp variable looks very suspicious" flx suggested to recreate the archive: "I think 4.19-2 would be better. There are no changes to coreboot or anything. It also doesn't need a new git tag" -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
