Hanno Böck writes:
Hi Sam,On Thu, 07 Jun 2012 19:06:08 -0400 Sam Varshavchik <[email protected]> wrote: > Hanno Böck writes: > > > So the correct way should be another test for root, e.g. > > test `id -u` != 0 > > > > I've prepared a patch. > > This is for both Makefile.in and Makefile.am to avoid the need for > > autotools, however the first one gets generated automatically, only > > the second one probably needs to be applied to courier. > > Please note however that this fixes the issue ONLY for > > module.esmtp, although it seems to be > > prevalent all over the couriere Makefile.am files. I wanted first to > > discuss if this is the correct approach to fix it. If you're okay > > with that, I'll send you further patches for the others. > > Although the intent seems to be ok, the patch itself does not really > work. Can you be more specific? At my local tests, it worked. What's the issue with it? What do you think the best approach to check for root would be?
I don't see how it could possibly work. With the change applied, the install command becomes:
/bin/install -c `test `id -u` != 0 || echo -o daemon -g daemon`And "make install" fails, because the shell parses the backticks in an unintended way. Did you try running 'make install', with this change, yourself?
pgp7F8SyuPOXw.pgp
Description: PGP signature
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ courier-users mailing list [email protected] Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users
