1-5 OK, pushed.
On 25.03.2013 16:26, Jakub Filak wrote:
+ def handle_signal(signum, frame):
+ while True:
+ try:
+ os.wait3(os.WNOHANG)
+ except OSError as ex:
+ logging.debug(ex.message)
+ break
It is not obvious that the exception is actually an expected state, a
short comment would be helpful.
+def glib_sigchld_signal_handler(callback, data=None):
+ #pylint: disable=W0613
+ def handle_signal(source, condition, data):
+ while source.read():
+ pass
+
Same thing, it is not obvious why you eat the whole input silently.
Although I don't like closures, it's probably simpler and more
straightforward in your case. Otherwise the code looks good.
Michal
