I think the functionality belongs in the mainstream. Whether it is better to use that PR or the patch - I leave to others to discuss. But I'd prefer to have it built-in rather than an add-on.
On Thu, May 11, 2017 at 9:41 AM, Jeffrey Walton <noloa...@gmail.com> wrote: > Hi Everyone, > > Our current GZip classes do not support filenames, filetimes or comments. > We have an optional patch that provides them at > https://www.cryptopp.com/wiki/Gzip#Patch. > > We recently got a PR to do the same at https://github.com/weidai11/ > cryptopp/pull/418. I closed it because we had the patch, but it may have > been premature. > > My question is, should we use the PR or patch to add the functionality? > Or, should we leave it as an add-on? > > Jeff > > -- > -- > You received this message because you are subscribed to the "Crypto++ > Users" Google Group. > To unsubscribe, send an email to cryptopp-users-unsubscribe@ > googlegroups.com. > More information about Crypto++ and this group is available at > http://www.cryptopp.com. > --- > You received this message because you are subscribed to the Google Groups > "Crypto++ Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to cryptopp-users+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Regards, Mouse -- -- You received this message because you are subscribed to the "Crypto++ Users" Google Group. To unsubscribe, send an email to cryptopp-users-unsubscr...@googlegroups.com. More information about Crypto++ and this group is available at http://www.cryptopp.com. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
