svn commit: rev 57386 - cocoon/trunk/src/java/org/apache/cocoon/components/thread

[giacomo]

Author: giacomo
Date: Wed Nov 10 13:51:40 2004
New Revision: 57386

Modified:
   cocoon/trunk/src/java/org/apache/cocoon/components/thread/BoundedQueue.java
   cocoon/trunk/src/java/org/apache/cocoon/components/thread/LinkedQueue.java
   cocoon/trunk/src/java/org/apache/cocoon/components/thread/ThreadPool.java
Log:
fixing possible race condition

Modified: 
cocoon/trunk/src/java/org/apache/cocoon/components/thread/BoundedQueue.java
==============================================================================
--- cocoon/trunk/src/java/org/apache/cocoon/components/thread/BoundedQueue.java 
(original)
+++ cocoon/trunk/src/java/org/apache/cocoon/components/thread/BoundedQueue.java 
Wed Nov 10 13:51:40 2004
@@ -59,7 +59,7 @@
     /**
      * DOCUMENT ME!
      *
-     * @return
+     * @return 
      */
     public int getQueueSize(  )
     {

Modified: 
cocoon/trunk/src/java/org/apache/cocoon/components/thread/LinkedQueue.java
==============================================================================
--- cocoon/trunk/src/java/org/apache/cocoon/components/thread/LinkedQueue.java  
(original)
+++ cocoon/trunk/src/java/org/apache/cocoon/components/thread/LinkedQueue.java  
Wed Nov 10 13:51:40 2004
@@ -32,11 +32,6 @@
     extends EDU.oswego.cs.dl.util.concurrent.LinkedQueue
     implements Queue
 {
-    //~ Instance fields 
--------------------------------------------------------
-
-    /** The size */
-    protected int m_size = 0;
-
     //~ Methods 
----------------------------------------------------------------
 
     /**
@@ -44,31 +39,6 @@
      */
     public int getQueueSize(  )
     {
-        return m_size;
-    }
-
-    /**
-     * @see EDU.oswego.cs.dl.util.concurrent.LinkedQueue#extract()
-     */
-    protected synchronized Object extract(  )
-    {
-        synchronized( head_ )
-        {
-            if( head_.next != null )
-            {
-                --m_size;
-            }
-
-            return super.extract(  );
-        }
-    }
-
-    /**
-     * @see 
EDU.oswego.cs.dl.util.concurrent.LinkedQueue#insert(java.lang.Object)
-     */
-    protected void insert( final Object object )
-    {
-        super.insert( object );
-        ++m_size;
+        return -1;
     }
 }

Modified: 
cocoon/trunk/src/java/org/apache/cocoon/components/thread/ThreadPool.java
==============================================================================
--- cocoon/trunk/src/java/org/apache/cocoon/components/thread/ThreadPool.java   
(original)
+++ cocoon/trunk/src/java/org/apache/cocoon/components/thread/ThreadPool.java   
Wed Nov 10 13:51:40 2004
@@ -20,7 +20,7 @@
  * of  a pool of threads
  *
  * @author <a href="mailto:giacomo.at.apache.org";>Giacomo Pati</a>
- * @version CVS $Id: ThreadPool.java,v 1.1 2004/06/16 14:39:21 giacomo Exp $
+ * @version CVS $Id$
  */
 public interface ThreadPool
 {
@@ -104,9 +104,10 @@
     int getPriority(  );
 
     /**
-     * Current size of the queue
+     * Current size of the queue.
      *
-     * @return current size of queue
+     * @return current size of queue. If the size of the queue is not
+     *         maintained by an implementation -1 should be returned.
      */
     int getQueueSize(  );