On Thu, 3 Mar 2005, Derosa, Anthony CIV NAVAIR 2035, 2, 205/214 wrote: > What do you think about Chuck's concerns regarding strcat() > vs. strncat()?
I'm no expert either, but usually the purpose of strncat() is to avoid a buffer overrun when copying an arbitrary-sized string into a statically-sized buffer (as the string may be longer than the buffer). Since you're sizing the buffer dynamically to the exact string size, I don't think there's anything wrong with using strcpy/strcat here (as long as you check that the buffer is not NULL -- and you do). > (I *didn't* regenerate this with diff, is that OK? > I just changed the "1" to "2" and removed some whitespace.): Mind the spaces/tabs in the *original* code. As long as what you edited is in your newly-added (or replacement) code, it should still apply. HTH, Igor > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Dave Korn > > To: [EMAIL PROTECTED] Oh, and <http://cygwin.com/acronyms/#PCYMTNQREAIYR>. Thanks. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ [EMAIL PROTECTED] ZZZzz /,`.-'`' -. ;-;;,_ [EMAIL PROTECTED] |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "The Sun will pass between the Earth and the Moon tonight for a total Lunar eclipse..." -- WCBS Radio Newsbrief, Oct 27 2004, 12:01 pm EDT -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/