Jorge Luis Zapata Muga <jorgeluis.zap...@gmail.com> writes:

> This series of patches add support for the Neuros Technologies OSD2
> board (http://wiki.neurostechnology.com/index.php/OSD_2.0_HD). It is a
> multimedia player/recorder based on DM6446.
>
> Sorry for the noise about sending the patches too many times,
> hopefully this will be the last time :)
>
> Signed-off-by: Jorge Luis Zapata <jorgeluis.zap...@gmail.com>
> ---
>  arch/arm/mach-davinci/Kconfig             |    8 +++++
>  arch/arm/mach-davinci/Makefile            |    1 +
>  arch/arm/mach-davinci/board-ntosd_644xa.c |   45 
> +++++++++++++++++++++++++++++
>  3 files changed, 54 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-davinci/board-ntosd_644xa.c
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index 05a80ca..e359a8c 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -53,6 +53,14 @@ config MACH_SFFSDR
>         Say Y here to select the Lyrtech Small Form Factor
>         Software Defined Radio (SFFSDR) board.
>
> +config MACH_NTOSD_644XA
> +     bool "Neuros OSD (644x Revision A)"
> +     default n
> +     depends on ARCH_DAVINCI_DM644x
> +     help
> +       Configure this option to use Neuros OSD dm644x revision A
> +          hardware
> +
>  config DAVINCI_MUX
>       bool "DAVINCI multiplexing support"
>       depends on ARCH_DAVINCI
> diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile
> index b3bb132..2e9656c 100644
> --- a/arch/arm/mach-davinci/Makefile
> +++ b/arch/arm/mach-davinci/Makefile
> @@ -19,4 +19,5 @@ obj-$(CONFIG_CP_INTC)                       += cp_intc.o
>  obj-$(CONFIG_MACH_DAVINCI_EVM)       += board-dm644x-evm.o
>  obj-$(CONFIG_MACH_DAVINCI_DM646X_EVM)        += board-dm646x-evm.o
>  obj-$(CONFIG_MACH_DAVINCI_DM355_EVM) += board-dm355-evm.o
> +obj-$(CONFIG_MACH_NTOSD_644XA)               += board-ntosd_644xa.o
>  obj-$(CONFIG_MACH_SFFSDR)            += board-sffsdr.o

The names chosen here are a bit confusing.  AFAIK, there isn't a SoC
named dm6446A and it looks like the 'A' is actually the rev. A of the
board, right?  IIUC, the board is actually called the Neuros OSD2,
right?

So rather than putting the SoC in the board name, how about

  config MACH_NEUROS_OSD2

and name the board file board-neuros-osd2.c

> diff --git a/arch/arm/mach-davinci/board-ntosd_644xa.c
> b/arch/arm/mach-davinci/board-ntosd_644xa.c
> new file mode 100644
> index 0000000..23ec948
> --- /dev/null
> +++ b/arch/arm/mach-davinci/board-ntosd_644xa.c
> @@ -0,0 +1,45 @@
> +/*
> + * Neuros Technologies OSD2 board support
> + *
> + * Copyright (C) 2009 Jorge Luis Zapata <jorgeluis.zap...@gmail.com>
> + *
> + * Based on DV-EVM platform
> + * This code is placed under the terms of the GNU General Public License v2
> + *
> + */
> +
> +
> +#include <linux/init.h>
> +#include <linux/dma-mapping.h>
> +
> +#include <asm/mach-types.h>
> +
> +#include <asm/mach/arch.h>
> +
> +#include <mach/dm644x.h>
> +#include <mach/common.h>
> +
> +static void __init ntosd_644xa_map_io(void)
> +{
> +     davinci_map_common_io();
> +     dm644x_init();
> +}
> +
> +static __init void ntosd_644xa_init(void)
> +{
> +}
> +
> +static __init void ntosd_644xa_irq_init(void)
> +{
> +     davinci_irq_init();
> +}
> +
> +MACHINE_START(NTOSD_644XA, "Neuros OSD 644x Revision A")
> +     .phys_io      = IO_PHYS,
> +     .io_pg_offst  = (__IO_ADDRESS(IO_PHYS) >> 18) & 0xfffc,
> +     .boot_params  = (DAVINCI_DDR_BASE + 0x100),
> +     .map_io       = ntosd_644xa_map_io,
> +     .init_irq     = ntosd_644xa_irq_init,
> +     .timer        = &davinci_timer,
> +     .init_machine = ntosd_644xa_init,
> +MACHINE_END
> -- 
> 1.6.2.2

Also, for the next version of this series, note that the board/SoC
code has changed so this will have to be updated slightly.  See
board-dm644x-evm.c for details.

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to