Hello.
On 07/30/2012 11:22 AM, Heiko Schocher wrote:
> add OF support for the davinci nand controller.
> Signed-off-by: Heiko Schocher <h...@denx.de>
> Cc: davinci-linux-open-source@linux.davincidsp.com
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: devicetree-disc...@lists.ozlabs.org
> Cc: linux-...@lists.infradead.org
> Cc: David Woodhouse <dw...@infradead.org>
> Cc: Grant Likely <grant.lik...@secretlab.ca>
> Cc: Sekhar Nori <nsek...@ti.com>
> Cc: Wolfgang Denk <w...@denx.de>
> Cc: Scott Wood <scottw...@freescale.com>
[...]
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index d94b03c..f386b3c 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
[...]
> @@ -518,9 +519,75 @@ static struct nand_ecclayout hwecc4_2048 __initconst = {
> },
> };
>
> +#if defined(CONFIG_OF)
> +static const struct of_device_id davinci_nand_of_match[] = {
> + {.compatible = "ti,davinci-nand", },
> + {},
> +}
I have only one question: have you ever try to compile this patch with
CONFIG_OF enabled? If you have, you would have noticed:
drivers/mtd/nand/davinci_nand.c:527: error: expected ‘,’ or ‘;’ before ‘extern’
> +MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
No need to worry now, I'll send out the trivial patch...
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
