> -----Original Message----- > From: Ohad Ben-Cohen [mailto:o...@wizery.com] > Sent: Tuesday, January 15, 2013 4:49 AM > To: Nori, Sekhar > Cc: Tivy, Robert; davinci-linux-open-source; linux-arm; Ring, Chris; > Grosen, Mark; r...@landley.net; linux-...@vger.kernel.org; Chemparathy, > Cyril > Subject: Re: [PATCH v5 6/9] ARM: davinci: Remoteproc driver support for > OMAP-L138 DSP > > On Tue, Jan 15, 2013 at 2:29 PM, Sekhar Nori <nsek...@ti.com> wrote: > > May be rproc_alloc() could auto-assign the firmware name to something > > like 'rproc%d-fw' if firmware name passed to it is NULL? > > I prefer we use name-based filenames instead to make it easier for > users (and us developers). > > We can probably do something like "rproc-%s-fw" with pdata->name > assuming we/you do maintain a meaningful name in the latter.
This sounds good, although it will introduce the need to handle dynamic storage for the generated name. I think I can jam that storage on the end of the already-dynamically-sized 'struct rproc + sizeof(pdata)' allocation in rproc_alloc(). Thanks & Regards, - Rob > > Thanks, > Ohad. _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source