On 18/08/10 16:05, Martin J. Evans wrote: > If you are reading this Tim, please skip to end as it raises a > DBISTATE_VERSION issue I could use a pointer on. > > On 09/08/10 15:00, Martin J. Evans wrote: >> John Scoles wrote: >>> Well story two of the 'two bit' version of DBD::Oracle 1.25 >>> >>> You can find release candidate 2 here >>> >>> http://svn.perl.org/modules/dbd-oracle/trunk/DBD-Oracle-1.25-RC2.tar.gz >>> >>> This one has some minor changes from Martin Evans, though I could not >>> find any issues with the Makfile.PL myself. >>> and hopefully I got rid of the warning error in the .xs file for >>> OCILobLocatorIsInit_log_stat >>> >>> And of course the usual bunch of POD changes. >>> >>> Cheers >>> John Scoles >>> >>> -- >>> New! Learn why & how to love your data with Pythian's new webinar series. >>> Topics, details & register: http://www.pythian.com/webinars >>> >> >> Sorry for taking so long to try this RC. >> >> The gzipped tar file you reference appears to be doubly gzipped BTW. >> >> OCILobLocatorIsInit problem still seems to exist for me: >> >> cc -c -I/home/oracle/instantclient_11_1//sdk/include >> -I/usr/local/lib/perl/5.10.0/auto/DBI -D_REENTRANT -D_GNU_SOURCE >> -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include >> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -DVERSION=\"1.25\" >> -DXS_VERSION=\"1.25\" -fPIC "-I/usr/lib/perl/5.10/CORE" -Wall >> -Wno-comment -DUTF8_SUPPORT -DORA_OCI_VERSION=\"11.1.0.6\" -DORA_OCI_102 >> Oracle.c >> Oracle.xs: In function ‘XS_DBD__Oracle__db_ora_lob_is_init’: >> Oracle.xs:486: warning: passing argument 4 of ‘OCILobLocatorIsInit’ >> makes pointer from integer without a cast >> /home/oracle/instantclient_11_1//sdk/include/ociap.h:7297: note: >> expected ‘boolean *’ but argument is of type ‘boolean’ >> >> Other than the usual 26exe_array test this seems to work ok here. >> >> Hope you enjoyed YAPC::EU 2010. >> >> Martin > > Update. Since I upgraded to DBI 1.613 DBD::Oracle 1.25 rc2 segfaults in the > 31lob.t test after 5 tests: > > ~/DBD-Oracle-1.25-RC2$ prove -vb t/31lob.t > t/31lob.t .. > 1..12 > ok 1 - returned valid locator > ok 2 - inserted into BLOB successfully > ok 3 - got back what we put in > ok 4 - returned valid locator > ok 5 - returned valid locator > Failed 7/12 subtests > > Test Summary Report > ------------------- > t/31lob.t (Wstat: 6 Tests: 5 Failed: 0) > Non-zero wait status: 6 > Parse errors: Bad plan. You planned 12 tests but ran 5. > Files=1, Tests=5, 0 wallclock secs ( 0.06 usr 0.00 sys + 0.17 cusr 0.08 > csys = 0.31 CPU) > Result: FAIL > > ~/DBD-Oracle-1.25-RC2$ perl -I blib/lib -Iblib/arch t/31lob.t > 1..12 > ok 1 - returned valid locator > ok 2 - inserted into BLOB successfully > ok 3 - got back what we put in > ok 4 - returned valid locator > ok 5 - returned valid locator > Aborted > > Also, the DiscardString stuff that was added stopped working. > > RC1 works with DBI 1.613 (no segfault) but the DiscardString stuff doesn't. > > DBD::Oracle 1.24a also does not do DiscardString with DBI 1.613. > > It appears the DiscardString stuff nolonger works because 7th March 2010 Tim > changed DBISTATE_VERSION back to 94 from 95 and DBD::Oracle says > DBISTATE_VERSION > 94. > > svn comment was: > > Revert DBISTATE_VERSION to 94. Tweak related comments. > Add note about "*" callback being an undocumented hack. > > I've no idea why this occurred but either it needs putting back or > DBD::Oracle needs changing to 93 or checking DBIXS_VERSION instead of > DBISTATE_VERSION - if you are reading this Tim perhaps you could give me a > clue. > > I'm sorry but I go on holiday at the end of this week so I am way too busy to > look at this now. For now, I've reverted to DBI 1.613 and DBD::Oracle RC1 but > with the check on DBISTATE_VERSION changed to 93. > > Martin
John, To fix the DiscardString issue above could you please change #if DBISTATE_VERSION > 94 to #if DBIXS_REVISION >= 13590 in oci8.c around line 3793. Thanks. Martin -- Martin J. Evans Easysoft Limited http://www.easysoft.com
