Well I made that ping patch for DBIx::Connector a few months ago on one of my production boxes with no impact but then again I am not doing anything fancy (no rac raid etc).
If it is critical to DBDx::Connector to ensure a query can be run then no, if you are going for 100% work alike betweeen all DBDs then no again and I am sure H.Merijn would like that. An option would be nice as well Cheers John ---------------------------------------- > Subject: Re: Oracle ping > From: da...@justatheory.com > Date: Mon, 5 Nov 2012 10:26:52 -0800 > CC: c...@cam.ac.uk; dbi-dev@perl.org > To: martin.ev...@easysoft.com > > On Nov 5, 2012, at 7:59 AM, Martin J. Evans <martin.ev...@easysoft.com> wrote: > > > Just to reiterate what I eventually said. I don't want ping changed in > > DBD::Oracle. > > > > All I was saying is you should only read anything useful into ping > > returning false and not true unless your only purpose is like Oracle's > > OCIPing which checks your connection is still there (although not usable > > for some things). I believe the connection caching only does anything when > > ping returns false. > > Hrm. Well I wonder if I *should* just use DBI->ping in DBIx::Connector for > Oracle rather than `select 1 from dual`. Or perhaps make it an option to > switch to the select statement. Thoughts? > > David >
