Il 08/01/2013 02:06, Jakub Wilk ha scritto:
> Does debian/patches/compilation_fixes really fix only "compilation on Debian
> systems"?
I split this patch into several patches.
> I see several problems with the __fls function:
> - You can't use "__" in your own identifiers; such names are reserved.
The function was usend only in the BitOps.h file, so I renamed it.
> - The implementation uses x86 assembly.
I completed the generic implementation, added an implementation based on
__builtin_clzl and implemented a selection mechanism in configure.ac.
The priority is:
x86 implementation
__builtin_clzl implementation
generic implementation
> - The unsigned long -> int typecast looks redundant to me.
The typecast as been removed. The result was the same indeed.
> Typo in src/optimize/lbfgs.f: THE THE -> THE.
> Typo in src/optimize/lbfgsb.f: easible -> feasible.
Both have been fixed.
Bests,
Giulio.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
