Here's a review, only a few thing to fix:
Ping me when ready.
Almost right:
Files: debian/*
2009, Denis Briand <de...@narcan.fr> is 2009-2010
2008 Barry deFreese <bddeb...@comcast.net is missing
for Files: * the years are not clear expect the first entry
so I'd write
Copyright: 2009 Maher Awamy <mu...@muhri.net>
Aaron Lehmann <aar...@vitelus.com>
Joshua Kwan <jo...@triplehelix.org>
Pedro Villavicencio Garrido <pvill...@gnome.cl>
Denis Briand <de...@narcan.fr>
The quoted license text is of GPL-2 -- not GPL-2+ as it should be --
(mind the "or later option" is missing)
Best is if you copy the license grant from main.c and add the "On
Debian.." paragraph
There are two, almost indentical manpages. If
- the one in the source tree is valid, remove the done in debian
- if the one in the debian tree is valid, patch the one in the source
tree and remove the one in the debian tree.
The name in the manpage is inconsitent: Title says "gtk-theme-switch"
but body says "gtk-theme-switch2". I'd update this to reflect the binary
name.
--
tobi
Am Sonntag, den 26.10.2014, 14:59 +0200 schrieb Marius Gavrilescu:
> Tobias Frost <t...@debian.org> writes:
>
> > as Eriberto mentioned in an earlier review of your package [1], your
> > d/copyright is incomplete.
> >
> > On a side note, please consider commments from reviewers
>
> I thought I fixed this.
>
> > do not file new RFS bugs -- it would have been appropiate here to
> > reopen #739911.
>
> I'll remember this.
>
> I've uploaded a fixed version to mentors [0]. Do I still need to submit
> a RFS for it?
>
> [0]: http://mentors.debian.net/package/gtk-theme-switch
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
