Source: serverstats
Version: 0.8.2-10
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that serverstats could not be built reproducibly.

The attached patch removes umask variability from the build system. Once
applied, serverstats can be built reproducibly in our reproducible
toolchain.

I think a better fix would be to drop the use of DH_FIXPERMS_EXCLUDE
(which
is deprecated anyway) and make the changes you want in another hook.
This
would have the added benefit of being more explicit about the changes
between a "regular" package and what serverstats needs to do. Just a
thought.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
diff --no-dereference -urNad serverstats.orig/serverstats-0.8.2/debian/rules 
serverstats/serverstats-0.8.2/debian/rules
--- serverstats.orig/serverstats-0.8.2/debian/rules     2015-04-29 
08:53:30.402722878 +0100
+++ serverstats/serverstats-0.8.2/debian/rules  2015-04-29 08:56:45.823359795 
+0100
@@ -15,3 +15,4 @@
        chown nobody:nogroup debian/serverstats/var/lib/serverstats/rrd
        chown www-data:www-data debian/serverstats/var/lib/serverstats/graph
        cp config.sample/* debian/serverstats/etc/serverstats/
+       find debian/serverstats/usr/share/doc/serverstats/ 
debian/serverstats/etc/serverstats/ -type f -exec chmod 0644 {} \;

Reply via email to