Hi Jakub, thanks a lot for your review - much appreciated!
Quoting Jakub Wilk (2015-09-10 16:21:26)
> >If dose-ceve is installed (and new enough) then build-rdeps will use it
> >to calculate the reverse build dependencies of a binary packages. If
> >dose-ceve is not installed (or too old) then it will warn that it will
> >use the old unreliable behavior instead.
>
> I don't like the idea of that the command semantics completely changes
> when you install or uninstall a package. I'd rather see build-rdeps fail
> with no output if dose-ceve can't be used.
fair enough.
How about doing it the following way then:
If dose-ceve is not installed, throw an error message and tell the user to
either install the dose-extra package or use the option --simple-mode which
uses the old behaviour.
> >If dose-ceve is installed (and new enough) then the old behaviour can be
> >forced with the --without-ceve command line argument.
>
> I don't like the option name. Most people don't know what ceve stands
> for, and it's an implementation detail anyway. (What if edos^Wdose
> maintainers decide to rename it to dose-evec? ;>)
That is actually a not too far fetched possibility XD
This problem is solved with my above proposal. If you don't like that proposal,
I'm open to suggestions of how to name it.
> Your patch doesn't seem to handle contrib and non-free correctly. I get:
>
> >Reverse Build-depends in contrib:
> >---------------------------------
> >
> >No reverse build-depends found for dh-autoreconf.
>
> even though of course there ARE packages in contrib build-depending on
> dh-autoreconf.
I will address this problem in my next patch - thanks for spotting it!
> >+ $packages_path =~
> >s/_source_Sources$/_binary-${opt_buildarch}_Packages/;
>
> The need for *_Packages should be documented in the REQUIREMENTS section
> of the manpage.
Indeed. Will add that in my next patch.
> On my machine, your implementation is ~100x slower than the current one.
> :\
If you know a piece of software that analyzes the interdependencies of 40k
binary packages and 20k source packages in a shorter time, I'm open for
suggestions!
cheers, josch
signature.asc
Description: signature
