Source: mini-buildd
Version: 1.0.8
Severity: wishlist

Hi,

please quote multi-word parameters passed to schroot in the syslog, so
that the syslog entry can be pasted into a shell for debugging.

For example (manual line breaks):

BAD:
Dec 27 16:14:34 spinturn mini_buildd.builder          (0208): INFO
: cron-apt_0.9.3.1-1~testSID+0:amd64: Running sbuild: sbuild
--dist=sid-test-experimental --arch=amd64
--chroot=mini-buildd-sid-amd64
--chroot-setup-command=cp 
/var/lib/mini-buildd/var/spool/54aad2009c2ded5ff96475b4350273b8011ca0e7/apt_sources.list
 /etc/apt/sources.list
--chroot-setup-command=cat /etc/apt/sources.list
--chroot-setup-command=cp 
/var/lib/mini-buildd/var/spool/54aad2009c2ded5ff96475b4350273b8011ca0e7/apt_preferences
 /etc/apt/preferences
--chroot-setup-command=cat /etc/apt/preferences
--chroot-setup-command=apt-key add 
/var/lib/mini-buildd/var/spool/54aad2009c2ded5ff96475b4350273b8011ca0e7/apt_keys

GOOD:
Dec 27 16:14:34 spinturn mini_buildd.builder          (0208): INFO
: cron-apt_0.9.3.1-1~testSID+0:amd64: Running sbuild: sbuild
--dist=sid-test-experimental --arch=amd64
--chroot=mini-buildd-sid-amd64
--chroot-setup-command="cp 
/var/lib/mini-buildd/var/spool/54aad2009c2ded5ff96475b4350273b8011ca0e7/apt_sources.list
 /etc/apt/sources.list"
--chroot-setup-command="cat /etc/apt/sources.list"
--chroot-setup-command="cp 
/var/lib/mini-buildd/var/spool/54aad2009c2ded5ff96475b4350273b8011ca0e7/apt_preferences
 /etc/apt/preferences"
--chroot-setup-command="cat /etc/apt/preferences"
--chroot-setup-command="apt-key add 
/var/lib/mini-buildd/var/spool/54aad2009c2ded5ff96475b4350273b8011ca0e7/apt_keys"

Thanks for considering.

Greetings
Marc

Reply via email to