Hi, thanks for agreeing to sponsor this!
On 01/28/2016 02:03 AM, Adam Borowski wrote: > On Wed, Jan 27, 2016 at 12:40:33AM +0100, Christian Seiler wrote: >> I am looking for a sponsor for my package "tiny-initramfs" > > Looks good to me. There's just a few minor nits: > > codespell: > ./tiny_initramfs.c:89: moduels ==> modules > > manually noticed: > configure.ac:66: alternativ => alternative > tiny_initramfs.c:83: Begun => Began I fixed those typos upstream (couldn't push it yet, because github's down), and I've cherry-picked that fix as debian/patches/0002*.patch. > configure: WARNING: optimization level other than -Os specified in CFLAGS, > this will increase your binary size. This warning is part of the upstream build system I made because I wanted to make sure that somebody compiling it by themselves notices if they pass a non-optimal compiler flag. The problem is that Debian by default sets -O2 and you can't easily override that unless you want to mess with all the hardening stuff in great detail - so the alternative is to just use export DEB_CFLAGS_MAINT_APPEND = -Os to make sure -Os is the last flag passed to gcc, so that it overrides the -O2 that Debian specifies earlier. That results in the correct binary (i.e. the smaller one). The _APPEND = -Os is also documented somewhere on the Debian wiki as the standard procedure of how to pass different optimization levels. So that results in the following situation: - (upstream hat) I don't want to get rid of the warning, because it is really useful for people compiling it manually. - (Debian hat) The warning is spurious here, but I don't want to have to carry a patch just to get rid of a harmless build warning for all eternity. Of course, if you know a non-involved way of performing a better check in configure.ac, I'm all ears. > configure: WARNING: debugging option -g specified in CFLAGS, this will > increase your binary size. This is actually spurious, I only found that out while packaging for Debian: -g doesn't actually increase the _stripped_ binary size, so passing it is perfectly fine, because Debian strips the binaries anyway. I've removed that upstream and cherry-picked the removal of that warning as debian/patches/0003*.patch. > These are small enough that it's up to you: do you prefer to fix these now, > or do you want me to upload as-is, to be fixed in a subsequent version? Except for the -O2 warning (which I think should remain for now) I've fixed this and re-uploaded the package to mentors, with the same version number as before. Note that because github is currently down, mentors complains that the watch file doesn't work. I didn't touch that file and it worked perfectly before, so please ignore that. Again, thanks for agreeing to sponsor my package! Regards, Christian
signature.asc
Description: OpenPGP digital signature
