Hi Brian,

Yes, this seems like a reasonable patch to send upstream.

Jelmer

On Thu, Jan 28, 2016 at 01:32:39PM +1100, Brian May wrote:
> Jelmer,
> 
> Do you think this is a patch that should go upstream?
> 
> Regards
> 
> > diff -Nru heimdal-1.6~rc2+dfsg/debian/patches/parallel-build-dependencies 
> > heimdal-1.6~rc2+dfsg/debian/patches/parallel-build-dependencies
> > --- heimdal-1.6~rc2+dfsg/debian/patches/parallel-build-dependencies 
> > 1969-12-31 16:00:00.000000000 -0800
> > +++ heimdal-1.6~rc2+dfsg/debian/patches/parallel-build-dependencies 
> > 2015-10-02 17:05:54.000000000 -0700
> > @@ -0,0 +1,23 @@
> > +Description: Fix header dependencies for parallel builds
> > + The heimdal package builds with dh --parallel, but a header which is
> > + generated at build-time is not marked as a dependency of the programs
> > + that depend on it for building.  Correct this so that parallel builds work
> > + reliably.
> > +Author: Steve Langasek <steve.langa...@ubuntu.com>
> > +
> > +Index: heimdal-1.6~rc2+dfsg/kdc/Makefile.am
> > +===================================================================
> > +--- heimdal-1.6~rc2+dfsg.orig/kdc/Makefile.am
> > ++++ heimdal-1.6~rc2+dfsg/kdc/Makefile.am
> > +@@ -19,9 +19,9 @@
> > + hprop_SOURCES = hprop.c mit_dump.c hprop.h
> > + hpropd_SOURCES = hpropd.c hprop.h
> > + 
> > +-kstash_SOURCES = kstash.c headers.h
> > ++kstash_SOURCES = kstash.c headers.h $(srcdir)/kdc-protos.h
> > + 
> > +-string2key_SOURCES = string2key.c headers.h
> > ++string2key_SOURCES = string2key.c headers.h $(srcdir)/kdc-protos.h
> > + 
> > + digest_service_SOURCES = \
> > +   digest-service.c
> > diff -Nru heimdal-1.6~rc2+dfsg/debian/patches/series 
> > heimdal-1.6~rc2+dfsg/debian/patches/series
> > --- heimdal-1.6~rc2+dfsg/debian/patches/series      2015-04-25 
> > 09:34:04.000000000 -0700
> > +++ heimdal-1.6~rc2+dfsg/debian/patches/series      2015-10-02 
> > 16:26:39.000000000 -0700
> > @@ -20,3 +20,4 @@
> >  050_kadmin_to_usr_bin
> >  051_bug746486-memleak
> >  060_no_build_string
> > +parallel-build-dependencies
> -- 
> Brian May <b...@debian.org>

Attachment: signature.asc
Description: PGP signature

Reply via email to