2016-06-26 20:24 GMT+02:00 Kurt Roeckx <k...@roeckx.be>:

> On Sun, Jun 26, 2016 at 06:53:42PM +0200, Jérémy Lal wrote:
> >
> > I'm on it, and after a couple things i could solve, i need a "gentle
> push"
> > to continue solving these:
>
> They all seem to be about the same problem.  The structure has
> become opaque and you can't have it directly on the stack or in an
> other struct.  Instead you need to allocate it with TYPE_new(),
> which will give you a pointer back.  This will ensure that the
> allocated size is the correct one, since we might change the
> structure to add new fields and thing like that.  When you do
> things like sizeof(TYPE) you would get the size at compile time
> which might be a different one than the one at runtime.
>

These changes seem quite easy and doable for a novice like me.
However the whole part about BIO seems to be much harder to fix:
https://github.com/nodejs/node/blob/v4.x/src/node_crypto_bio.h
https://github.com/nodejs/node/blob/v4.x/src/node_crypto_bio.cc

Sadly, upstream is not considering moving soon to openssl 1.1.
https://github.com/nodejs/node/issues/4270

Jérémy.

Reply via email to