Bug#886439: byzanz-record should print messages on begin and end

[Jörg Sommer]

Markus Koschany hat am Sat 06. Jan, 17:41 (+0100) geschrieben:
> Am 06.01.2018 um 00:56 schrieb Jörg Sommer:
> > Package: byzanz
> > Version: 0.3.0+git20160312-2
> > Severity: wishlist
> > 
> > Hi,
> > 
> > it would be helpful if byzanz could print a message when the recording
> > begins and ends, because it's not always recogniseable what's happening,
> > esp. when the begin is delayed.
> > 
> > A proposal:
> > 
> > % byzanz-record --delay 4 -d 6
> > Starting recording in 4 seconds
> > Recording started
> > Recording stopped
> 
> Yes, that would be useful. Unfortunately upstream is no longer active
> but I would apply a patch for Debian if someone provided the code.

There are progress messages, already. They can be enabled with -v. Here's
a patch I would suggest to apply:

diff -u -r byzanz-0.3.0+git20160312/src/byzanz-record.1 
byzanz-0.3.0+git20160312+/src/byzanz-record.1
--- byzanz-0.3.0+git20160312/src/byzanz-record.1        2018-01-07 
13:42:31.655469207 +0100
+++ byzanz-0.3.0+git20160312+/src/byzanz-record.1       2011-03-30 
22:31:41.000000000 +0200
@@ -54,7 +54,7 @@
 Height of recording rectangle
 .TP
 \fB\-v\fR, \fB\-\-verbose\fR
-be verbose and print progress messages
+be verbose
 .TP
 \fB\-w\fR, \fB\-\-width\fR=\fIPIXEL\fR
 Width of recording rectangle
diff -u -r byzanz-0.3.0+git20160312/src/record.c 
byzanz-0.3.0+git20160312+/src/record.c
--- byzanz-0.3.0+git20160312/src/record.c       2015-12-09 09:32:44.000000000 
+0100
+++ byzanz-0.3.0+git20160312+/src/record.c      2018-01-07 13:36:35.549489063 
+0100
@@ -42,7 +42,7 @@
   { "y", 'y', 0, G_OPTION_ARG_INT, &area.y, N_("Y coordinate of rectangle to 
record"), N_("PIXEL") },
   { "width", 'w', 0, G_OPTION_ARG_INT, &area.width, N_("Width of recording 
rectangle"), N_("PIXEL") },
   { "height", 'h', 0, G_OPTION_ARG_INT, &area.height, N_("Height of recording 
rectangle"), N_("PIXEL") },
-  { "verbose", 'v', 0, G_OPTION_ARG_NONE, &verbose, N_("Be verbose"), NULL },
+  { "verbose", 'v', 0, G_OPTION_ARG_NONE, &verbose, N_("Print progress 
messages"), NULL },
   { NULL }
 };
 
@@ -198,6 +198,8 @@
   g_signal_connect (rec, "notify", G_CALLBACK (session_notify_cb), NULL);
   
   delay = MAX (delay, 1);
+  if (delay > 0)
+      verbose_print (_("Starting recording in %d seconds...\n"), delay);
   delay = (delay - 1) * 1000;
   duration = MAX (duration, 0);
   duration *= 1000;

Bye Jörg

signature.asc
Description: PGP signature